From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] gnttab: fix and clean up gnttab_set_version() Date: Wed, 17 Jun 2015 14:35:01 +0100 Message-ID: <55817785.9090105@citrix.com> References: <558189DB0200007800086205@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z5DUh-0001hQ-Aw for xen-devel@lists.xenproject.org; Wed, 17 Jun 2015 13:35:07 +0000 In-Reply-To: <558189DB0200007800086205@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Ian Campbell , Ian Jackson , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 17/06/15 13:53, Jan Beulich wrote: > - don't silently truncate frame numbers > - drop pointless nr_grant_entries() check from loop over reserved > entries (adding suitable BUILD_BUG_ON()s to validate that) > - adjust types > - rename d to currd > - formatting This should be at least 3 patches to separate the bug fix, the optimization and the reformatting. David