All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] ARM: mvebu: do not check machine in mvebu_pm_init()
Date: Wed, 17 Jun 2015 17:32:42 +0200	[thread overview]
Message-ID: <5581931A.7080800@free-electrons.com> (raw)
In-Reply-To: <1434456785-23696-4-git-send-email-thomas.petazzoni@free-electrons.com>

Hi Thomas,

On 16/06/2015 14:12, Thomas Petazzoni wrote:
> The mvebu_pm_init() initializes the support for suspend/resume, and
> before doing that, it checks if we are on a board on which
> suspend/resume is actually supported. However, this check is already
> done by mvebu_armada_xp_gp_pm_init(), and there is no need to
> duplicate the check: callers of mvebu_pm_init() should now what they
> are doing.
> 
> This commit is done in preparation to the addition of suspend/resume
> support on Armada 38x.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>


Thanks,

Gregory

> ---
>  arch/arm/mach-mvebu/pm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/pm.c b/arch/arm/mach-mvebu/pm.c
> index 6573a8f..eca650b 100644
> --- a/arch/arm/mach-mvebu/pm.c
> +++ b/arch/arm/mach-mvebu/pm.c
> @@ -182,9 +182,6 @@ int mvebu_pm_init(void (*board_pm_enter)(void __iomem *sdram_reg, u32 srcmd))
>  	struct device_node *np;
>  	struct resource res;
>  
> -	if (!of_machine_is_compatible("marvell,armadaxp"))
> -		return -ENODEV;
> -
>  	np = of_find_compatible_node(NULL, NULL,
>  				     "marvell,armada-xp-sdram-controller");
>  	if (!np)
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2015-06-17 15:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 12:12 [PATCH 0/9] ARM: mvebu: add suspend to RAM support for Armada 38x Thomas Petazzoni
2015-06-16 12:12 ` [PATCH 1/9] ARM: mvebu: fix suspend to RAM on big-endian configurations Thomas Petazzoni
2015-06-16 12:12   ` Thomas Petazzoni
2015-06-17 15:24   ` Gregory CLEMENT
2015-06-17 15:24     ` Gregory CLEMENT
2015-06-16 12:12 ` [PATCH 2/9] ARM: mvebu: prepare set_cpu_coherent() for future extension Thomas Petazzoni
2015-06-17 15:28   ` Gregory CLEMENT
2015-06-16 12:12 ` [PATCH 3/9] ARM: mvebu: do not check machine in mvebu_pm_init() Thomas Petazzoni
2015-06-17 15:32   ` Gregory CLEMENT [this message]
2015-06-16 12:13 ` [PATCH 4/9] ARM: mvebu: prepare mvebu_pm_store_bootinfo() to support multiple SoCs Thomas Petazzoni
2015-06-17 16:12   ` Gregory CLEMENT
2015-06-16 12:13 ` [PATCH 5/9] ARM: mvebu: prepare pm-board.c for the introduction of Armada 38x support Thomas Petazzoni
2015-06-17 16:13   ` Gregory CLEMENT
2015-06-16 12:13 ` [PATCH 6/9] ARM: mvebu: add suspend/resume support for Armada 38x Thomas Petazzoni
2015-06-16 12:13 ` [PATCH 7/9] ARM: mvebu: add suspend/resume related definitions in Armada 38x Device Tree Thomas Petazzoni
2015-06-16 12:13 ` [PATCH 8/9] ARM: mvebu: add suspend/resume DT information for Armada 388 GP Thomas Petazzoni
2015-06-16 12:13 ` [PATCH 9/9] ARM: mvebu: adjust board name and compatible " Thomas Petazzoni
2015-06-17 16:31   ` Gregory CLEMENT
2015-06-17 20:48     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5581931A.7080800@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.