Re: [Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On 06/17/2015 05:01 AM, Kővágó Zoltán wrote:

>>> Can you explain why the complexity is needed, i.e. why we can't just
>>> require full paths always?
>>
>> Keeping the short names is required for -netdev backward compatibility.
>>
>> Restricting to short or full (i.e. something= or foo.bar.something=, but
>> disallow bar.something=) should not be a problem.  I'm not sure this
>> simplifies things much though.  We have to build the full path anyway,
>> and I think bar.something= is just a convenient thing we get almost for
>> free ...
> 
> With the current implementation you can specify (see my previous patch)
> in.try-poll=off in case of alsa. If we would need full paths, it would
> look like opts.data.in.try-poll=off, which is probably not something we
> want.

Elsewhere in the thread, it was suggested that you use a flat union.
That would simplify the full path to opts.in.try-poll, rather than
opts.data.in.try-poll.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]