From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Iyt-0004Bd-PC for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Iyk-0001uU-7V for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:26:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Iyk-0001uK-1F for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:26:30 -0400 Message-ID: <5581C9E2.70103@redhat.com> Date: Wed, 17 Jun 2015 21:26:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <553E0514.5030700@msgid.tls.msk.ru> <553E115B.40303@redhat.com> <5581BB90.2030802@msgid.tls.msk.ru> In-Reply-To: <5581BB90.2030802@msgid.tls.msk.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] libcacard: use the library? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel On 17/06/2015 20:25, Michael Tokarev wrote: > 27.04.2015 13:37, Paolo Bonzini =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> >> On 27/04/2015 11:44, Michael Tokarev wrote: >>> Currently we link individual object files from libcacard >>> to qemu-system binaries, this way (from Makefile.objs): >>> >>> libcacard-y +=3D libcacard/cac.o libcacard/event.o >>> libcacard-y +=3D libcacard/vcard.o libcacard/vreader.o >>> ... >>> common-obj-$(CONFIG_SMARTCARD_NSS) +=3D $(libcacard-y) >>> >>> Why can't we use the actual library, and just add the >>> linker flag, -Ilibcacard -lcacard? >> >> Because that would require people to use "libtool --mode=3Dexecute gdb= " to >> debug qemu. This is not a problem for me, but I know that some people >> on the list are allergic to the GNU build tools. >> >> I would be okay for this, and I would also be okay with making libcaca= rd >> standalone. Making it standalone would also bypass the problem of >> verbose debugging command lines. You've already done most of the work >> with your patches to stop using libqemuutil.a. As a small step in tha= t >> direction, I've sent a patch to remove use of qemu-common.h. >> >> Somebody has to write some Autoconf/Automake and package it up, I gues= s. >=20 > Ok. I wrote small configure script (just a simple shell script, > no auto*tools, since the configuration of it is stright-forward, > we just need to check libglib and libnss versions using pkg-config > and check if libtool works) and a small Makefile for libcacard. Thanks, can you put a git repo somewhere? I'll autoconfiscate it, in the meanwhile you can perhaps look at adding submodule support similar to pixman? Paolo > Now the question is what to do with it? How to make it external > and where to put it? What to use for its version? How to migrate > to its usage in qemu? >=20 > I propose to put it in a separate git repository on qemu project > site and remove it from qemu source, since it is definitely not a > hard requiriment to have smartcard support. Or maybe we can keep > it for a release in qemu source, adding it as a submodule, with > a tweak to be able to use external lib instead of embedded copy > if external is available. >=20 > Thanks, >=20 > /mjt >=20