From: roopa <roopa@cumulusnetworks.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH net-next v2] ipv4: include NLM_F_APPEND flag in append route notifications
Date: Wed, 17 Jun 2015 13:37:23 -0700 [thread overview]
Message-ID: <5581DA83.9060504@cumulusnetworks.com> (raw)
In-Reply-To: <CAE4R7bBAWVKV4vtv7kJFS+MxzWMTHjxPJJ=h-+7kj8WSrZjn3Q@mail.gmail.com>
On 6/17/15, 11:30 AM, Scott Feldman wrote:
> On Wed, Jun 17, 2015 at 11:07 AM, Roopa Prabhu
> <roopa@cumulusnetworks.com> wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
>> in newroute notifications if the route add was an append.
>> (This is similar to how NLM_F_REPLACE is already part of new
>> route replace notifications today)
>>
>> This helps userspace determine if the route add operation was
>> an append.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> ---
>> v2: flip if condition around append and change |= to =
>> (feedback from Alexander Duyck and Scott Feldman)
> Is this a bug fix for net, or a new feature for net-next? Regardless,
>
> Acked-by: Scott Feldman <sfeldma@gmail.com>
I could not decide between net and net-next.
....but the patch applies cleanly against net if Dave decides to pick it
up for net.
next prev parent reply other threads:[~2015-06-17 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 18:07 [PATCH net-next v2] ipv4: include NLM_F_APPEND flag in append route notifications Roopa Prabhu
2015-06-17 18:30 ` Scott Feldman
2015-06-17 20:37 ` roopa [this message]
2015-06-21 17:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5581DA83.9060504@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.