From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5LYF-0006ED-8U for qemu-devel@nongnu.org; Wed, 17 Jun 2015 18:11:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5LYE-0003KT-6i for qemu-devel@nongnu.org; Wed, 17 Jun 2015 18:11:19 -0400 Message-ID: <5581F075.2060405@ilande.co.uk> Date: Wed, 17 Jun 2015 23:11:01 +0100 From: Mark Cave-Ayland MIME-Version: 1.0 References: <1434578651-16057-1-git-send-email-i.am.cormac.obrien@gmail.com> In-Reply-To: <1434578651-16057-1-git-send-email-i.am.cormac.obrien@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] macio: remove nonexistent interrupt on pin 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cormac O'Brien , agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org On 17/06/15 23:04, Cormac O'Brien wrote: > The current macio implementation declares an interrupt that doesn't appear to > exist in the hardware or any other emulator implementation. OpenBIOS detects > this interrupt and generates an 'interrupts' property in the macio device tree > entry. Mac OS 9 halts boot when it detects this interrupt, so it has been > removed to permit further progress in the boot process. > > Signed-off-by: Cormac O'Brien > > --- > hw/misc/macio/macio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c > index 063ad80..306c95e 100644 > --- a/hw/misc/macio/macio.c > +++ b/hw/misc/macio/macio.c > @@ -132,8 +132,6 @@ static int macio_common_initfn(PCIDevice *d) > SysBusDevice *sysbus_dev; > int ret; > > - d->config[0x3d] = 0x01; // interrupt on pin 1 > - > ret = qdev_init(DEVICE(&s->cuda)); > if (ret < 0) { > return ret; > Reviewed-by: Mark Cave-Ayland ATB, Mark.