From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v3][PATCH 03/16] xen/vtd: create RMRR mapping
Date: Thu, 18 Jun 2015 14:23:20 +0800
Message-ID: <558263D8.2060607@intel.com>
References: <1433985325-16676-1-git-send-email-tiejun.chen@intel.com>
	<1433985325-16676-4-git-send-email-tiejun.chen@intel.com>
	<5581621D020000780008603A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5581621D020000780008603A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: yang.z.zhang@intel.com, andrew.cooper3@citrix.com, kevin.tian@intel.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 2015/6/17 18:03, Jan Beulich wrote:
>>>> On 11.06.15 at 03:15, <tiejun.chen@intel.com> wrote:
>> --- a/xen/arch/x86/mm/p2m.c
>> +++ b/xen/arch/x86/mm/p2m.c
>> @@ -927,10 +927,16 @@ int set_identity_p2m_entry(struct domain *d, unsigned long gfn,
>>           }
>>
>>           gfn_unlock(p2m, gfn, 0);
>> -        return ret;
>>       }
>> +    else
>> +        ret = 0;
>>
>> -    return 0;
>> +    if( ret == 0 )
>> +    {
>> +        ret = iommu_map_page(d, gfn, gfn, IOMMUF_readable|IOMMUF_writable);
>> +    }
>
> Pointless braces and missing blank in the if() statement. I also think
> this should be added right when the function gets introduced.

Finally I think we should remove this change since p2m_set_entry() 
always set iommu page map internally.

Thanks
Tiejun