Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC

[Alexander Sverdlin <alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>]

Hi!

On 18/06/15 11:00, ext Sekhar Nori wrote:
>> +	if (davinci_i2c_read_reg(dev, DAVINCI_I2C_ICPID2_REG) == 0x2206) {
>> > +		dev_dbg(dev->dev, "Keystone SoC detected\n");
>> > +		d = 6;
>> > +	}
> I think its better to use a different compatible string for i2c on
> keystone devices rather than using a fixed hardcoded IP version.

Yeah, this should have been done from the beginning, when the driver has been
re-used for Keystone, but this time is already missed, so I don't want
to introduce huge incompatibility with the existing device-trees.

And from the other PoV, device-trees are for something one cannot probe. We
can probe for Keystone revisions and can free the end-user from this headache
completely.

-- 
Best regards,
Alexander Sverdlin.