All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: btrfs <linux-btrfs@vger.kernel.org>
Subject: Unified output for btrfs? Fwd: Re: [Libguestfs] [PATCH] New API: btrfs_device_stats
Date: Thu, 18 Jun 2015 17:26:15 +0800	[thread overview]
Message-ID: <55828EB7.5030705@cn.fujitsu.com> (raw)

Hi all,

My colleagues are working on adding btrfs support to libguestfs.

But just like  Pino's complain, even in v4.1-rc1 btrfs-progs we reworked 
some UI of mkfs, the output from other btrfs subcommands still have 
their own output format.

Any idea to provide a unified output format for all btrfs commands?
Maybe a json output will be quite good?
Or an independent btrfs user-space library?

Or this is just what higher level program should do?
Just like the btrfs filters in fstests?

Thanks,
Qu

-------- Forward Message --------
Subject: Re: [Libguestfs] [PATCH] New API: btrfs_device_stats
Date: Thu, 18 Jun 2015 10:41:56 +0200
From: Pino Toscano <ptoscano@redhat.com>
TO: libguestfs@redhat.com

Hi,

On Thursday 18 June 2015 11:01:37 Cao jin wrote:
> > Speaking of this: you said that you have a colleague working on
> > btrfs-progs? What about suggesting to create some machine-parseable
> > output (csv, xml, yaml, json, whatever) so extracting the results of
> > btrfs tools is a lot more easy?
> >
>
> Yes, I forward your suggestion and consult him, the result is not
> surprised:( Here is what I learned from him:
>    For the btrfs-progs cmds who output strings, the output are plain,
> don`t have patterns. Seen some guys who want a formatted output, they do
> a filter by themself, it not reasonable to ask btrfs-progs to output
> formatted strings.

This is exactly the issue here: every btrfs command has a totally
different formatting for its output. Just let him take a look at all
the commands implemented so far in libguestfs, you can easily spot
that:
- btrfs subvolume list
- btrfs subvolume show
- btrfs qgroup show
- btrfs balance status
- btrfs scrub status
- btrfs device stats
all have different custom parsers for each of their outputs.

Compare that to e.g. the -m parameter for parted, so it outputs fields
separated by semi-colon.

-- 
Pino Toscano

_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs




                 reply	other threads:[~2015-06-18  9:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55828EB7.5030705@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.