From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5ZET-0004T3-3p for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:47:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5ZEO-0003wE-UE for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:47:49 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5ZEO-0003w6-Lo for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:47:44 -0400 Message-ID: <5582BDEE.4070700@msgid.tls.msk.ru> Date: Thu, 18 Jun 2015 15:47:42 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1432749229-4861-1-git-send-email-armbru@redhat.com> In-Reply-To: <1432749229-4861-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com 27.05.2015 20:53, Markus Armbruster wrote: > Since we now require GLib 2.22+ (commit f40685c), we don't have to > work around lack of g_strcmp0() anymore. > qga/main.c | 2 +- > - if (domain && strcmp(domain, "syslog") == 0) { > + if (g_strcmp0(domain, "syslog") == 0) { Why bother? To me the current version is easier to read, it is traditional and working, while for g_strcmp0() I have to look up documentation. /mjt