From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5Zh5-00034p-MU
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 09:17:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5Zgy-0002mx-As
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 09:17:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58443)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Z5Zgy-0002mL-6S
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 09:17:16 -0400
Message-ID: <5582C4D7.3030908@redhat.com>
Date: Thu, 18 Jun 2015 15:17:11 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150612140845.GD2749@TopQuark.net> <55817D66.2090303@redhat.com>
	<20150618125819.GA7886@TopQuark.net>
In-Reply-To: <20150618125819.GA7886@TopQuark.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers
 on forward jumps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Donohue <qemu-devel@PaulSD.com>
Cc: qemu-devel@nongnu.org



On 18/06/2015 14:58, Paul Donohue wrote:
> On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote:
>> On 12/06/2015 16:08, Paul Donohue wrote:
>>> +static inline int64_t get_max_clock_jump(void)
>>> +{
>>> +    // This should be small enough to prevent excessive interrupts from being
>>> +    // generated by the RTC on clock jumps, but large enough to avoid frequent
>>> +    // unnecessary resets in idle VMs.
>> This is not how comments are layed out in QEMU...
> Oops.  Sorry, I'm not sure how I missed that.  Force of habit from 
> other projects, I guess...
> 
>>> +    return 60 * get_ticks_per_sec();
>>> +}
>>> +
>>>  /*
>>>  *   * Low level clock functions
>>>  *     */
>> ... and it also looks like your editor has mangled this patch.
> Ugh, yes.  I do remember noticing that, and I thought I fixed it, but 
> apparently not.
> 
> I will correct and send an updated patch.

No problem, I fixed this already.

Paolo