From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/HVM: EOI handling function adjustments
Date: Thu, 18 Jun 2015 14:29:38 +0100
Message-ID: <5582C7C2.9050702@citrix.com>
References: <5582DAE80200007800086A00@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=604697e0d=Andrew.Cooper3@citrix.com>)
	id 1Z5ZtA-0001rA-Oy
	for xen-devel@lists.xenproject.org; Thu, 18 Jun 2015 13:29:52 +0000
In-Reply-To: <5582DAE80200007800086A00@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, Kevin Tian <kevin.tian@intel.com>, Eddie Dong <eddie.dong@intel.com>, Jun Nakajima <jun.nakajima@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 18/06/15 13:51, Jan Beulich wrote:
> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -421,18 +421,17 @@ void vlapic_EOI_set(struct vlapic *vlapi
>      if ( hvm_funcs.handle_eoi )
>          hvm_funcs.handle_eoi(vector);
>  
> -    if ( vlapic_test_and_clear_vector(vector, &vlapic->regs->data[APIC_TMR]) )
> -        vioapic_update_EOI(vlapic_domain(vlapic), vector);
> -
> -    hvm_dpci_msi_eoi(current->domain, vector);
> +    vlapic_handle_EOI(vlapic, vector);
>  }
>  
> -void vlapic_handle_EOI_induced_exit(struct vlapic *vlapic, int vector)
> +void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector)
>  {
> +    struct domain *d = vlapic_domain(vlapic);
> +
>      if ( vlapic_test_and_clear_vector(vector, &vlapic->regs->data[APIC_TMR]) )
> -        vioapic_update_EOI(vlapic_domain(vlapic), vector);
> +        vioapic_update_EOI(d, vector);
>  
> -    hvm_dpci_msi_eoi(current->domain, vector);
> +    hvm_dpci_msi_eoi(d, vector);

It might be worth retaining an ASSERT(current->domain == d) at this point.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>