From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/2] gdbsx_guestmemio: Allow it to check
	domain.
Date: Thu, 18 Jun 2015 17:59:10 +0100
Message-ID: <5582F8DE.2060203@citrix.com>
References: <1434642932-24807-1-git-send-email-dslutz@verizon.com>
	<1434642932-24807-2-git-send-email-dslutz@verizon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1434642932-24807-2-git-send-email-dslutz@verizon.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <don.slutz@gmail.com>, "security@xenproject.org" <security@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>, Mukesh Rathor <mukesh.rathor@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 18/06/15 16:55, Don Slutz wrote:
> gdbsx_guest_mem_io() does not get d passed, it expects to handle
> the domain lookup itself.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> CC: Don Slutz <don.slutz@gmail.com>

As for the change itself, Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>

However, I think the commit message needs improving.  Specifically, the
caller of XEN_DOMCTL_gdbsx_guestmemio is expected to use DOMID_IDLE to
interact with the hypervisor, rather than a domain, which doesn't
interact well with with the domain rcu lock.

> ---
>  xen/common/domctl.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index ce517a7..2a2d203 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -443,6 +443,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>      case XEN_DOMCTL_createdomain:
>      case XEN_DOMCTL_getdomaininfo:
>      case XEN_DOMCTL_test_assign_device:
> +    case XEN_DOMCTL_gdbsx_guestmemio:
>          d = NULL;
>          break;
>      default: