From: Dave Hansen <dave.hansen@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Kanaka Juvva <kanaka.d.juvva@linux.intel.com>
Cc: kanaka.d.juvva@intel.com, glenn.p.williamson@intel.com,
matt.fleming@intel.com, will.auld@intel.com, andi@firstfloor.org,
ananth.s.narayan@intel.com, linux-kernel@vger.kernel.org,
andrew.j.herdrich@intel.com, tony.luck@intel.com,
peterz@infradead.org, x86@kernel.org, mingo@redhat.com,
hpa@zytor.com, luto@amacapital.net, dvlasenk@redhat.com,
bp@alien8.de, peter.p.waskiewicz.jr@intel.com,
imammedo@redhat.com, bp@suse.de, ross.zwisler@linux.intel.com,
jacob.w.shin@gmail.com, dirk.j.brandewie@intel.com,
vikas.shivappa@intel.com, edwin.verplanke@intel.com,
tomasz.kantecki@intel.com
Subject: Re: [PATCH v1 2/2] x86, perf,cqm: handle CPU hotplug
Date: Thu, 18 Jun 2015 13:00:14 -0700 [thread overview]
Message-ID: <5583234E.5080807@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1506182146160.4107@nanos>
On 06/18/2015 12:47 PM, Thomas Gleixner wrote:
>> > @@ -1239,12 +1239,15 @@ static inline void cqm_pick_event_reader(int cpu)
>> > int phys_id = topology_physical_package_id(cpu);
>> > int i;
>> >
>> > + mutex_lock(&cache_mutex);
> I already explained it to Vikas. You CANNOT take a mutex in that code
> path as it runs with interrupts disabled on a CPU which cannot
> schedule.
How did lockdep not blow up and scream about this?
next prev parent reply other threads:[~2015-06-18 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 18:49 [PATCH v1 2/2] x86, perf,cqm: handle CPU hotplug Kanaka Juvva
2015-06-18 19:47 ` Thomas Gleixner
2015-06-18 20:00 ` Dave Hansen [this message]
2015-06-18 20:09 ` Thomas Gleixner
2015-06-23 20:32 ` Vikas Shivappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5583234E.5080807@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=ananth.s.narayan@intel.com \
--cc=andi@firstfloor.org \
--cc=andrew.j.herdrich@intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dirk.j.brandewie@intel.com \
--cc=dvlasenk@redhat.com \
--cc=edwin.verplanke@intel.com \
--cc=glenn.p.williamson@intel.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=jacob.w.shin@gmail.com \
--cc=kanaka.d.juvva@intel.com \
--cc=kanaka.d.juvva@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=peterz@infradead.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tomasz.kantecki@intel.com \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@intel.com \
--cc=will.auld@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.