From: David Ahern <dsahern@gmail.com>
To: Lukas Wunner <lukas@wunner.de>, Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified
Date: Thu, 18 Jun 2015 14:26:25 -0600 [thread overview]
Message-ID: <55832971.4070603@gmail.com> (raw)
In-Reply-To: <20150618195955.GA4755@wunner.de>
On 6/18/15 1:59 PM, Lukas Wunner wrote:
> E.g. the Debian "linux-tools" package makes use of that feature:
>
> MAKE_PERF := $(MAKE) prefix=/usr V=1 ARCH=$(KERNEL_ARCH_PERF) EXTRA_WARNINGS=-Wno-error
>
> Source: http://anonscm.debian.org/viewvc/kernel/dists/trunk/linux-tools/debian/build/tools/perf/Makefile?view=markup (line 29)
>
>
> The "prefix" parameter is handed down from Makefile.perf to Makefile.build
> because it's invoked with $(MAKE), so the command line parameters are
> inherited to Makefile.build:
>
> $(Q)$(MAKE) $(build)=perf
>
> Source: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/tools/perf/Makefile.perf#n282
>
>
> That "prefix" feature is broken in all 4.1 release candidates because a
It worked for me last week with OL6.
I created a standalone perf rpm with 4.1-rc6; it builds just fine with
_prefix (rpm variable) set to /usr:
%build
# prepare directories
rm -rf $RPM_BUILD_ROOT
cd perf-%{kversion}
%global perf_make \
make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1
HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=%{_prefix}
%{perf_make} DESTDIR=$RPM_BUILD_ROOT all
###
### install
###
%install
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
cd perf-%{kversion}
%{perf_make} DESTDIR=$RPM_BUILD_ROOT lib=%{_lib} install man
next prev parent reply other threads:[~2015-06-18 20:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201506181332.t5IDWuUq027242@int-mx13.intmail.prod.int.phx2.redhat.com>
2015-06-18 19:29 ` [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified Jiri Olsa
2015-06-18 19:59 ` Lukas Wunner
2015-06-18 20:26 ` David Ahern [this message]
2015-06-18 20:39 ` Lukas Wunner
2015-06-18 21:51 ` Jiri Olsa
2015-06-18 22:07 ` David Ahern
2015-06-18 22:17 ` Jiri Olsa
2015-06-19 11:54 ` Lukas Wunner
2015-06-19 14:19 ` Arnaldo Carvalho de Melo
2015-06-18 21:52 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55832971.4070603@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.