From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5gwX-0006pf-B7 for qemu-devel@nongnu.org; Thu, 18 Jun 2015 17:01:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5gwU-0001dK-5g for qemu-devel@nongnu.org; Thu, 18 Jun 2015 17:01:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5gwU-0001dB-0T for qemu-devel@nongnu.org; Thu, 18 Jun 2015 17:01:46 -0400 Message-ID: <558331B3.9050304@redhat.com> Date: Thu, 18 Jun 2015 15:01:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1434636521-24426-1-git-send-email-w.bumiller@proxmox.com> In-Reply-To: <1434636521-24426-1-git-send-email-w.bumiller@proxmox.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DD3EV3cItXxcwW3dU6DlAD9RPXRvJM4vs" Subject: Re: [Qemu-devel] [PATCH] vvfat: add a label option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wolfgang Bumiller , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DD3EV3cItXxcwW3dU6DlAD9RPXRvJM4vs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/18/2015 08:08 AM, Wolfgang Bumiller wrote: > Till now the vvfat filesystem's label was hardcoded to be s/Till/Until/ > "QEMU VVFAT", now you can pass a file.label=3Dlabelname option > to the -drive to change it. >=20 > Signed-off-by: Wolfgang Bumiller > --- > block/vvfat.c | 25 ++++++++++++++++++++++--- > qapi/block-core.json | 3 ++- > 2 files changed, 24 insertions(+), 4 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1453,13 +1453,14 @@ > # @fat-type: #optional FAT type: 12, 16 or 32 > # @floppy: #optional whether to export a floppy image (true) or > # partitioned hard disk (false; default) > +# @label: #optional override default label Missing '(since 2.4)', and also a description of the default text, as well as the fact that the text is limited to 11 bytes. Not sure if it is also worth mentioning that shorter strings padded with trailing spaces to the proper length. Otherwise looks reasonable. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DD3EV3cItXxcwW3dU6DlAD9RPXRvJM4vs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVgzG0AAoJEKeha0olJ0NqfWUH/ixoEkEwP5fnX9l/NC/VqjAn Lg/nupsoyCE0VMmoKZBjUg8g9GrwZKmyr7OyagwkElfR4qXKJO9sih8KlPyDphCE nMGVW54nxX7lkEQd7ZR5E42glFiqYFfwGzJq+ZGTLzq94bvpwtWf1Hl8Px+7oiUX mhjftuMJhogHIVN3nQUcTu9eKfsvq/gF/yAIB2sFfHmfTtHg63pJZ7W/MlF/q0iX 5eUNxvTS1VKIuG0/uJpo8S8xaVJhVubkcDQiBxy50LQrHASyoil3FHoPDhScBdlZ YXDUgeHO87zkzdemsC/hQffZ1vpQO+7qyRKq2XRnYlXnAs0b5/DS+aFP73uRoec= =SBnD -----END PGP SIGNATURE----- --DD3EV3cItXxcwW3dU6DlAD9RPXRvJM4vs--