From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH] drm: bridge/dw_hdmi: Filter modes > 165MHz for DVI Date: Fri, 19 Jun 2015 09:31:49 +0800 Message-ID: <55837105.2060409@rock-chips.com> References: <1434582847-713-1-git-send-email-dianders@chromium.org> <20150617233040.GE7557@n2100.arm.linux.org.uk> <20150618085335.GF7557@n2100.arm.linux.org.uk> <20150618155545.GQ7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.131]) by gabe.freedesktop.org (Postfix) with ESMTP id B12758A3E8 for ; Thu, 18 Jun 2015 18:32:08 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Doug Anderson , Russell King - ARM Linux Cc: Fabio Estevam , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Andy Yan , Thierry Reding List-Id: dri-devel@lists.freedesktop.org RG91ZyAmIFJ1c3NlbGwsCgrlnKggMjAxNS82LzE5IDA6MTAsIERvdWcgQW5kZXJzb24g5YaZ6YGT Ogo+IFJ1c3NlbGwsCj4KPiBPbiBUaHUsIEp1biAxOCwgMjAxNSBhdCA4OjU1IEFNLCBSdXNzZWxs IEtpbmcgLSBBUk0gTGludXgKPiA8bGludXhAYXJtLmxpbnV4Lm9yZy51az4gd3JvdGU6Cj4+PiBQ ZXJoYXBzIHlvdSBjYW4gdHJ5IDxodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzU5 MDY3NzEvPgo+PiBTb21ldGhpbmcgbGlrZSB0aGF0IG5lZWRzIHRvIGJlIGRvbmUsIGJ1dCBsZXQn cyBnZXQgcmlkIG9mIHRoZSBtZHZpCj4+IHRoaW5nIGluIHN0cnVjdCBoZG1pX3Ztb2RlIC0gaXQg ZG9lc24ndCBiZWxvbmcgdGhlcmUsIGl0IGlzbid0IHBhcnQKPj4gb2YgdGhlIGN1cnJlbnRseSBz ZXQgdmlkZW8gbW9kZSwgYnV0IGJlY29tZXMgYSBwcm9wZXJ0eSBvZiB0aGUKPj4gY29ubmVjdGVk IHNpbmsuCj4+Cj4+IEknZCBhbHNvIHByZWZlciBpdCB0byBiZSBjYWxsZWQgImlzX2R2aV9zaW5r IiwgZXNwZWNpYWxseSBhcyBpdHMKPj4gZnVuY3Rpb24gaXMgY2hhbmdpbmcgZnJvbSAiaXMgaXQg YSBDRUEgbW9kZSIgdG8gImlzIHRoZSBhdHRhY2hlZAo+PiBkZXZpY2UgYSBEVkkgc2luayIuCj4+ Cj4+IEV2ZW4gYmV0dGVyIHdvdWxkIGJlIHRvIGNhbGwgaXQgImlzX2hkbWlfc2luayIgdG8gbWFp bnRhaW4gcG9zaXRpdmUKPj4gbG9naWMgd2l0aCBzaW5nbGUtbmVnYXRpb24gd2hlcmUgcmVxdWly ZWQsIHJhdGhlciB0aGFuIGRvdWJsZS0KPj4gbmVnYXRpb24gaW4gcGxhY2VzLgo+IFlha2lyOiBz b3VuZHMgbGlrZSB5b3Ugbm93IGhhdmUgc29tZSBmZWVkYmFjayBvbiB5b3VyIHBhdGNoIG5vdy4K PiBQZXJoYXBzIHlvdSBjYW4gc3BpbiBpdCB3aXRoIFJ1c3NlbGwncyBmZWVkYmFjaz8KPgo+IFdo ZW4geW91IHNlbmQgaXQgbmV4dCwgcGxlYXNlIG1ha2Ugc3VyZSB5b3UgaW5jbHVkZSBSdXNzZWxs IGluIHRoZQo+ICJUbyIgbGluZS4gIEJhc2VkIGF0IGxvb2tpbmcgYXQgd2hvIGNvbW1pdHRlZCB0 aGluZ3MgdG8gZHdfaGRtaSBpbiB0aGUKPiBwYXN0LCBJJ3ZlIGJlZW4gc2VuZGluZyBteSBwYXRj aGVzICJUbyI6Cj4gICAgICBQaGlsaXBwIFphYmVsCj4gICAgICBSdXNzZWxsIEtpbmcKPiAgICAg IFRoaWVycnkgUmVkaW5nCj4KPiAuLi5zbyBwZXJoYXBzIHRoYXQgd291bGQgYmUgZ29vZCBmb3Ig eW91IHRvIGRvLCB0b28/CgpPa2F5LCAgdGhhbmtzIGZvciB5b3VyIHJlbWluZC4KCj4+PiBJIGFt IG5vd2hlcmUgbmVhciBhbiBIRE1JIGV4cGVydC4gIElmIHlvdSBoYXZlIGEgYmV0dGVyIHN1Z2dl c3Rpb24KPj4+IHRoZW4gSSdtIG1vcmUgdGhhbiBoYXBweSBmb3IgeW91IHRvIHBvc3QgaXQgYW5k IGRyb3AgbXkgcGF0Y2guICBJbiBteQo+Pj4gbm9uLWV4cGVydCBvcGluaW9uLCBpdCB3b3VsZCBz ZWVtIGF3ZnVsbHkgc3RyYW5nZSBmb3IgYW4gQVYgcmVjZWl2ZXIKPj4+IHRvIG1vZGlmeSB0aGUg RURJRCB0aG91Z2ggdW5sZXNzIGl0IHdhcyBhY3RpdmVseSBpbnRlcnByZXRpbmcgdGhlCj4+PiBz aWduYWwgYW5kIGdlbmVyYXRpbmcgYSB3aG9sZSBuZXcgc2lnbmFsIG9uIHRoZSBvdGhlciBlbmQu ICBJbiBhbnkKPj4+IGNhc2UsIHBlcmhhcHMgeW91IGNhbiBmaW5kIHN1Y2ggYSBkZXZpY2UgYW5k IHRoYXQgd2lsbCBnaXZlIGluc2lnaHQgdG8KPj4+IGhvdyB3ZSBzaG91bGQgZGVhbCB3aXRoIGl0 LiAgVW50aWwgc3VjaCBhIGRldmljZSBpcyBmb3VuZCwgaXQgc2VlbXMKPj4+IGZydWl0bGVzcyB0 byBzcGVjdWxhdGUuCj4+IE5laXRoZXIgYW0gSSwgYnV0IEkgaGF2ZSBoYWQgdGhlIGFiaWxpdHkg dG8gZG8gc29tZSB0ZXN0aW5nIHdpdGggQVYKPj4gcmVjZWl2ZXJzIGluIHRoZSBwYXRoIG9mIGEg SERNSSBkZXZpY2UsIGFuZCBJJ3ZlIHNlZW4gaG93IHRoZXkgYmVoYXZlLgo+PiAoSSBtYWRlIGNv cGlvdXMgbm90ZXMgb24gdGhpcywgd2hpY2ggSSBpbnRlbmQgdG8gcHVibGlzaCB3aGVuIEkgaGF2 ZQo+PiBhIHJvdW5kIHR1aXQuKSAgVW5mb3J0dW5hdGVseSwgSSBoYXZlIG5vIERWSSBkZXZpY2Vz IHRvIHRlc3Qgd2l0aCwKPj4gYW5kIERWSSBkZXZpY2VzIGFyZSBhIGR5aW5nIGJyZWVkIC0gbW9z dCBtb25pdG9ycyB0b2RheSBjb21lIHdpdGgKPj4gSERNSSBzb2NrZXRzIGluc3RlYWQuCj4gQWgs IE9LLiAgSGF2ZSB5b3Ugc2VlbiBhbnkgdGhhdCBzcGVjaWZpY2FsbHkgY29uZnVzZSB0aGUgRFZJ IHZzLiBIRE1JIGJpdHM/Cj4KPiBJIHN0aWxsIGhhdmUgY29waW91cyBEVkkgZGV2aWNlcyBhcm91 bmQsIHBlcnNvbmFsbHkuICBJIGNvdWxkIGhhdmUKPiBzd29ybiB0aGF0IHN1cHBvcnRpbmcgIm9s ZGVyIGhhcmR3YXJlIiB3YXMgYWN0dWFsbHkgcHJldHR5IGltcG9ydGFudAo+IGluIExpbnV4LiAg Li4uYW5kIEkgY2FuIHN0aWxsIGJ1eSBwbGVudHkgb2YgRFZJIGRldmljZXMgb3V0IHRoZXJlLgo+ Cj4KPj4gVGhhdCdzIGEgc2hhbWUuLi4gSSdtIG5vdCBpbmNsaW5lZCB0byBBY2sgaXQgYXMtaXMg LSBhbmQgSSdkIGFsc28gbGlrZQo+PiB0byBzZWUgWWFraXIncyBwYXRjaCByZXdvcmtlZCBhcyBJ IG1lbnRpb25lZCBhYm92ZS4KPiBQZXJoYXBzIHdoZW4gWWFraXIgc3BpbnMgaGlzIHNlcmllcyBo ZSBjYW4gaW5jbHVkZSBhIHBhdGNoIGxpa2UgbWluZQo+IGluIGl0LiAgSXQgZG9lc24ndCBtYWtl IHNlbnNlIGZvciBtZSB0byByZS1zcGluIGl0IHVudGlsIGhpcyBpcwo+IHJlc29sdmVkLgpJIHdp bGwgcmViYXNlIG9uIHJ1c3NlbGwgc2VyaWVzIGFuZCByZS1zZW5kIG15IHBhdGNoIHRvZGF5LgoK LSBZYWtpcgo+IC1Eb3VnCj4KPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752064AbbFSBcx (ORCPT ); Thu, 18 Jun 2015 21:32:53 -0400 Received: from regular2.263xmail.com ([211.157.152.4]:45202 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbbFSBcs (ORCPT ); Thu, 18 Jun 2015 21:32:48 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 191.101.57.22 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <8face1090113026e15b36f11446d843b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm: bridge/dw_hdmi: Filter modes > 165MHz for DVI To: Doug Anderson , Russell King - ARM Linux References: <1434582847-713-1-git-send-email-dianders@chromium.org> <20150617233040.GE7557@n2100.arm.linux.org.uk> <20150618085335.GF7557@n2100.arm.linux.org.uk> <20150618155545.GQ7557@n2100.arm.linux.org.uk> Cc: Philipp Zabel , Thierry Reding , Heiko Stuebner , David Airlie , Andy Yan , Fabio Estevam , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" From: Yakir Yang Message-ID: <55837105.2060409@rock-chips.com> Date: Fri, 19 Jun 2015 09:31:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug & Russell, 在 2015/6/19 0:10, Doug Anderson 写道: > Russell, > > On Thu, Jun 18, 2015 at 8:55 AM, Russell King - ARM Linux > wrote: >>> Perhaps you can try >> Something like that needs to be done, but let's get rid of the mdvi >> thing in struct hdmi_vmode - it doesn't belong there, it isn't part >> of the currently set video mode, but becomes a property of the >> connected sink. >> >> I'd also prefer it to be called "is_dvi_sink", especially as its >> function is changing from "is it a CEA mode" to "is the attached >> device a DVI sink". >> >> Even better would be to call it "is_hdmi_sink" to maintain positive >> logic with single-negation where required, rather than double- >> negation in places. > Yakir: sounds like you now have some feedback on your patch now. > Perhaps you can spin it with Russell's feedback? > > When you send it next, please make sure you include Russell in the > "To" line. Based at looking at who committed things to dw_hdmi in the > past, I've been sending my patches "To": > Philipp Zabel > Russell King > Thierry Reding > > ...so perhaps that would be good for you to do, too? Okay, thanks for your remind. >>> I am nowhere near an HDMI expert. If you have a better suggestion >>> then I'm more than happy for you to post it and drop my patch. In my >>> non-expert opinion, it would seem awfully strange for an AV receiver >>> to modify the EDID though unless it was actively interpreting the >>> signal and generating a whole new signal on the other end. In any >>> case, perhaps you can find such a device and that will give insight to >>> how we should deal with it. Until such a device is found, it seems >>> fruitless to speculate. >> Neither am I, but I have had the ability to do some testing with AV >> receivers in the path of a HDMI device, and I've seen how they behave. >> (I made copious notes on this, which I intend to publish when I have >> a round tuit.) Unfortunately, I have no DVI devices to test with, >> and DVI devices are a dying breed - most monitors today come with >> HDMI sockets instead. > Ah, OK. Have you seen any that specifically confuse the DVI vs. HDMI bits? > > I still have copious DVI devices around, personally. I could have > sworn that supporting "older hardware" was actually pretty important > in Linux. ...and I can still buy plenty of DVI devices out there. > > >> That's a shame... I'm not inclined to Ack it as-is - and I'd also like >> to see Yakir's patch reworked as I mentioned above. > Perhaps when Yakir spins his series he can include a patch like mine > in it. It doesn't make sense for me to re-spin it until his is > resolved. I will rebase on russell series and re-send my patch today. - Yakir > -Doug > > >