From: Alexander Duyck <alexander.duyck@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 5/6] fm10k: update fm10k_slot_warn to use pcie_get_minimum link
Date: Thu, 18 Jun 2015 19:22:33 -0700 [thread overview]
Message-ID: <55837CE9.1080706@gmail.com> (raw)
In-Reply-To: <1434405656-10465-5-git-send-email-jacob.e.keller@intel.com>
On 06/15/2015 03:00 PM, Jacob Keller wrote:
> This is useful in cases where we connect to a slot at Gen3, but the slot
> is behind a bus which only connected at Gen2. This generally only
> happens when a PCIe switch is in the sequence of devices, and can be
> very confusing when you see slow performance with no obvious cause.
>
> I am aware this patch has a few lines that break 80 characters, but
> there does not seem to be a readable way to format them to less than 80
> characters. Suggestions welcome.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 105 +++++++++++++++++++--------
> 1 file changed, 76 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> index 37cd78f3ce24..d8ab6cdca456 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> @@ -1703,22 +1703,86 @@ static int fm10k_sw_init(struct fm10k_intfc *interface,
>
> static void fm10k_slot_warn(struct fm10k_intfc *interface)
> {
> - struct device *dev = &interface->pdev->dev;
> + enum pcie_link_width width = PCIE_LNK_WIDTH_UNKNOWN;
> + enum pci_bus_speed speed = PCI_SPEED_UNKNOWN;
> struct fm10k_hw *hw = &interface->hw;
> + int max_gts = 0, expected_gts = 0;
>
> - if (hw->mac.ops.is_slot_appropriate(hw))
If I am not mistaken I believe this is the only spot that uses the
is_slot_appropriate function in the upstream driver. You could just
drop it from the code if that is the case. I'll try to get to it in a
couple of weeks when I get back from vacation otherwise.
- Alex
next prev parent reply other threads:[~2015-06-19 2:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 22:00 [Intel-wired-lan] [PATCH 1/6] fm10k: disable service task during suspend Jacob Keller
2015-06-15 22:00 ` [Intel-wired-lan] [PATCH 2/6] [TRIVIAL] fm10k: remove comment about rtnl_lock around mbx operations Jacob Keller
2015-09-02 1:56 ` Singh, Krishneil K
2015-09-02 2:16 ` Singh, Krishneil K
2015-06-15 22:00 ` [Intel-wired-lan] [PATCH 3/6] fm10k: only prevent removal of default VID rules Jacob Keller
2015-09-02 1:57 ` Singh, Krishneil K
2015-09-02 2:17 ` Singh, Krishneil K
2015-06-15 22:00 ` [Intel-wired-lan] [PATCH 4/6] fm10k: reset Tx FIFO head and tail pointers as part of reset_work Jacob Keller
2015-06-24 20:03 ` Keller, Jacob E
2015-06-15 22:00 ` [Intel-wired-lan] [PATCH 5/6] fm10k: update fm10k_slot_warn to use pcie_get_minimum link Jacob Keller
2015-06-19 2:22 ` Alexander Duyck [this message]
2015-06-19 15:31 ` Keller, Jacob E
2015-09-02 1:58 ` Singh, Krishneil K
2015-09-02 2:18 ` Singh, Krishneil K
2015-06-15 22:00 ` [Intel-wired-lan] [PATCH 6/6] fm10k: update netdev perm_addr during reinit, instead of at up Jacob Keller
2015-09-02 1:59 ` Singh, Krishneil K
2015-09-02 2:18 ` Singh, Krishneil K
2015-09-02 1:55 ` [Intel-wired-lan] [PATCH 1/6] fm10k: disable service task during suspend Singh, Krishneil K
2015-09-02 2:16 ` Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55837CE9.1080706@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.