From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj Date: Fri, 19 Jun 2015 14:28:31 +0900 Message-ID: <5583A87F.5090807@samsung.com> References: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNeuFhCAwNuyblCAxOeydvCAxNDoyMywgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiBUaGUgZmllbGQgJ3ZtYScgb2YgJ2V4eW5vc19kcm1fZ2VtX29iaicgc3RydWN0dXJlIHdhcyBp bnRyb2R1Y2VkIGluCj4gMmEzMDk4ZmY2YzIxICgiZHJtL2V4eW5vczogYWRkIHVzZXJwdHIgZmVh dHVyZSBmb3IgZzJkIG1vZHVsZSIpIGJ1dCBpcwo+IG5vdCByZWZlcmVuY2VkIGFueXdoZXJlLgo+ IAo+IE9uZSBpbnN0YW5jZSBvZiAnZXh5bm9zX2RybV9nZW1fb2JqJyBtYXkgYmUgbWFwcGVkIHRv IG11bHRpcGxlCj4gdXNlci1zcGFjZSBWTUFzIHNvICd2bWEnIGZpZWxkIGRvZXMgbm90IGxvb2sg dXNlZnVsIGFueXdheS4KCktyenlzenRvZiwKClRoZSB2bWEgbWVtYmVyIHdvdWxkIGJlIHJlbW92 ZWQgYnkgYmVsb3cgcGF0Y2gsCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMv ZHJpLWRldmVsLzIwMTUtTWF5LzA4Mjc2NC5odG1sCgpUaGFua3MsCklua2kgRGFlCgo+IAo+IFNp Z25lZC1vZmYtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGsua296bG93c2tpQHNhbXN1bmcuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZ2VtLmggfCAyIC0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZ2VtLmggYi9kcml2ZXJzL2dwdS9kcm0vZXh5 bm9zL2V4eW5vc19kcm1fZ2VtLmgKPiBpbmRleCAzMDgxNzNjYjRmMGEuLjZmNDJlMjI0ODI4OCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZ2VtLmgKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZ2VtLmgKPiBAQCAtNjEsNyAr NjEsNiBAQCBzdHJ1Y3QgZXh5bm9zX2RybV9nZW1fYnVmIHsKPiAgICoJb3IgYXQgZnJhbWVidWZm ZXIgY3JlYXRpb24uCj4gICAqIEBzaXplOiBzaXplIHJlcXVlc3RlZCBmcm9tIHVzZXIsIGluIGJ5 dGVzIGFuZCB0aGlzIHNpemUgaXMgYWxpZ25lZAo+ICAgKglpbiBwYWdlIHVuaXQuCj4gLSAqIEB2 bWE6IGEgcG9pbnRlciB0byB2bV9hcmVhLgo+ICAgKiBAZmxhZ3M6IGluZGljYXRlIG1lbW9yeSB0 eXBlIHRvIGFsbG9jYXRlZCBidWZmZXIgYW5kIGNhY2hlIGF0dHJ1aWJ1dGUuCj4gICAqCj4gICAq IFAuUy4gdGhpcyBvYmplY3Qgd291bGQgYmUgdHJhbnNmZXJyZWQgdG8gdXNlciBhcyBrbXNfYm8u aGFuZGxlIHNvCj4gQEAgLTcxLDcgKzcwLDYgQEAgc3RydWN0IGV4eW5vc19kcm1fZ2VtX29iaiB7 Cj4gIAlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QJCWJhc2U7Cj4gIAlzdHJ1Y3QgZXh5bm9zX2RybV9n ZW1fYnVmCSpidWZmZXI7Cj4gIAl1bnNpZ25lZCBsb25nCQkJc2l6ZTsKPiAtCXN0cnVjdCB2bV9h cmVhX3N0cnVjdAkJKnZtYTsKPiAgCXVuc2lnbmVkIGludAkJCWZsYWdzOwo+ICB9Owo+ICAKPiAK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Fri, 19 Jun 2015 14:28:31 +0900 Subject: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj In-Reply-To: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> References: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> Message-ID: <5583A87F.5090807@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015? 06? 19? 14:23, Krzysztof Kozlowski wrote: > The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in > 2a3098ff6c21 ("drm/exynos: add userptr feature for g2d module") but is > not referenced anywhere. > > One instance of 'exynos_drm_gem_obj' may be mapped to multiple > user-space VMAs so 'vma' field does not look useful anyway. Krzysztof, The vma member would be removed by below patch, http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h > index 308173cb4f0a..6f42e2248288 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h > @@ -61,7 +61,6 @@ struct exynos_drm_gem_buf { > * or at framebuffer creation. > * @size: size requested from user, in bytes and this size is aligned > * in page unit. > - * @vma: a pointer to vm_area. > * @flags: indicate memory type to allocated buffer and cache attruibute. > * > * P.S. this object would be transferred to user as kms_bo.handle so > @@ -71,7 +70,6 @@ struct exynos_drm_gem_obj { > struct drm_gem_object base; > struct exynos_drm_gem_buf *buffer; > unsigned long size; > - struct vm_area_struct *vma; > unsigned int flags; > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbbFSF2k (ORCPT ); Fri, 19 Jun 2015 01:28:40 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:55971 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbbFSF2d convert rfc822-to-8bit (ORCPT ); Fri, 19 Jun 2015 01:28:33 -0400 X-AuditID: cbfee68f-f793b6d000005f66-4d-5583a87f3c0e MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <5583A87F.5090807@samsung.com> Date: Fri, 19 Jun 2015 14:28:31 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Krzysztof Kozlowski Cc: Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj References: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsWyRsSkQLd+RXOowec+A4vecyeZLK58fc9m 8eLeRRaL1y8MLfofv2a2ONv0ht1i0+NrrBaXd81hs5hxfh+TxYzJL9kcuDw2repk89j+7QGr x/3u40wem5fUe/RtWcXo8XmTXABbFJdNSmpOZllqkb5dAlfG7FUH2Qs6eSpOL7vP2sD4grOL kZNDQsBE4tC6i0wQtpjEhXvr2boYuTiEBJYySizbuIERpuj43imsEInpjBLbGk8wgyR4BQQl fky+xwJiMwuoS0yat4gZwhaROLJmKRuErS2xbOFrsLiQwH1GiclHcrsYOYB6tSSebTEECbMI qEpMuLCFFcRmA7InrrgP1ioqECbx4tUusFYRAUOJg7u3M4HcwCxwkUnie/MDdpCEsICfxJ1J i1kg5rtJ9K2/DtbAKeAuMWffRrBvJATeskv0fnjJArFNQOLb5EMsIEdICMhKbDrADPGkpMTB FTdYJjCKz0Ly2iwkr81C8tosJK8tYGRZxSiaWpBcUJyUXmSsV5yYW1yal66XnJ+7iREYy6f/ PevfwXj3gPUhRgEORiUe3oZlzaFCrIllxZW5hxhNgS6ayCwlmpwPTBh5JfGGxmZGFqYmpsZG 5pZmSuK8C6V+BgsJpCeWpGanphakFsUXleakFh9iZOLglGpg1PXeNHte9lnNtOU/NSZs9L1n uXDKRI6n3xr/RBxRmqllNFXGMiB79rcJD56ZvXjxYlkoqwT/aYfymIJJf/sPyzz55CYlxB9c xrh26ucG5Y5rn4RTuF6nhxbJWhdvaPSr1Os6pL1gZvMt/xXyCxZ8bqh7pRVhKL17npGhstfK A/w7tC3c7jLPV2Ipzkg01GIuKk4EAGCuAwfgAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsVy+t9jQd36Fc2hBvu2aln0njvJZHHl63s2 ixf3LrJYvH5haNH/+DWzxdmmN+wWmx5fY7W4vGsOm8WM8/uYLGZMfsnmwOWxaVUnm8f2bw9Y Pe53H2fy2Lyk3qNvyypGj8+b5ALYohoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0t LcyVFPISc1NtlVx8AnTdMnOALlNSKEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAG EtYwZtyfs5u94Dt3xdMdPg2M1zi7GDk5JARMJI7vncIKYYtJXLi3nq2LkYtDSGA6o8S2xhPM IAleAUGJH5PvsXQxcnAwC8hLHLmUDRJmFlCXmDRvEViJkMB9RonJR3JBSngFtCSebTEECbMI qEpMuLAFbDwbkD1xxX02EFtUIEzixatdYK0iAoYSB3dvZwJZyyxwkUnie/MDdpCEsICfxJ1J i1kg5rtJ9K2/DtbAKeAuMWffRrYJjAKzkFw3C+G6WUiuW8DIvIpRNLUguaA4KT3XUK84Mbe4 NC9dLzk/dxMjOOafSe1gXNlgcYhRgINRiYe3YVlzqBBrYllxZe4hRgkOZiUR3t+dQCHelMTK qtSi/Pii0pzU4kOMpkDfTWSWEk3OB6ajvJJ4Q2MTMyNLI3NDCyNjcyVx3pP5PqFCAumJJanZ qakFqUUwfUwcnFINjGE3s7NUlkQKPws911IueW4am+yi+kufA/L+cpRpc/a7pOTvKpq9V6JH 9tEck8mv18cvPiYVEKIrmCrJLv+DZfOmkhn7TFjLeLg/7Cxf72PbcurLMbE7ZzT/Xf9q/vZU 2c0lC661HInM4Tp044PYZ9YZtzt2yr2fLPQleYJtYw/fiydRDbXLS5RYijMSDbWYi4oTAXK+ mjcPAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 06월 19일 14:23, Krzysztof Kozlowski wrote: > The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in > 2a3098ff6c21 ("drm/exynos: add userptr feature for g2d module") but is > not referenced anywhere. > > One instance of 'exynos_drm_gem_obj' may be mapped to multiple > user-space VMAs so 'vma' field does not look useful anyway. Krzysztof, The vma member would be removed by below patch, http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html Thanks, Inki Dae > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h > index 308173cb4f0a..6f42e2248288 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h > +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h > @@ -61,7 +61,6 @@ struct exynos_drm_gem_buf { > * or at framebuffer creation. > * @size: size requested from user, in bytes and this size is aligned > * in page unit. > - * @vma: a pointer to vm_area. > * @flags: indicate memory type to allocated buffer and cache attruibute. > * > * P.S. this object would be transferred to user as kms_bo.handle so > @@ -71,7 +70,6 @@ struct exynos_drm_gem_obj { > struct drm_gem_object base; > struct exynos_drm_gem_buf *buffer; > unsigned long size; > - struct vm_area_struct *vma; > unsigned int flags; > }; > >