From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj Date: Fri, 19 Jun 2015 15:03:20 +0900 Message-ID: <5583B0A8.3040908@samsung.com> References: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> <5583A87F.5090807@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNeuFhCAwNuyblCAxOeydvCAxNDo0NiwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiAyMDE1LTA2LTE5IDE0OjI4IEdNVCswOTowMCBJbmtpIERhZSA8aW5raS5kYWVAc2Ftc3VuZy5j b20+Ogo+PiBPbiAyMDE164WEIDA27JuUIDE57J28IDE0OjIzLCBLcnp5c3p0b2YgS296bG93c2tp IHdyb3RlOgo+Pj4gVGhlIGZpZWxkICd2bWEnIG9mICdleHlub3NfZHJtX2dlbV9vYmonIHN0cnVj dHVyZSB3YXMgaW50cm9kdWNlZCBpbgo+Pj4gMmEzMDk4ZmY2YzIxICgiZHJtL2V4eW5vczogYWRk IHVzZXJwdHIgZmVhdHVyZSBmb3IgZzJkIG1vZHVsZSIpIGJ1dCBpcwo+Pj4gbm90IHJlZmVyZW5j ZWQgYW55d2hlcmUuCj4+Pgo+Pj4gT25lIGluc3RhbmNlIG9mICdleHlub3NfZHJtX2dlbV9vYmon IG1heSBiZSBtYXBwZWQgdG8gbXVsdGlwbGUKPj4+IHVzZXItc3BhY2UgVk1BcyBzbyAndm1hJyBm aWVsZCBkb2VzIG5vdCBsb29rIHVzZWZ1bCBhbnl3YXkuCj4+Cj4+IEtyenlzenRvZiwKPj4KPj4g VGhlIHZtYSBtZW1iZXIgd291bGQgYmUgcmVtb3ZlZCBieSBiZWxvdyBwYXRjaCwKPj4gaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxNS1NYXkvMDgyNzY0 Lmh0bWwKPj4KPiAKPiBJIHRoaW5rIGl0IGlzIGEgZGlmZmVyZW50IG9iamVjdC4gVGhlIHBhdGNo IGFib3ZlIHJlbW92ZXMgaXQgZnJvbQo+IHN0cnVjdCBnMmRfY21kbGlzdF91c2VycHRyLgo+IEhv d2V2ZXIgSSByZW1vdmVkIGl0IGZyb20gc3RydWN0IGV4eW5vc19kcm1fZ2VtX29iaiwgd2hlcmUg aXQgd2FzCj4gbmV2ZXIgcmVmZXJlbmNlZC4KCkFoLCByaWdodC4gVGhlcmUgd2FzIG15IG1pc3Rh a2UuCgpUaGFua3MsCklua2kgRGFlCgo+IAo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0b2YKPiAK Pj4gVGhhbmtzLAo+PiBJbmtpIERhZQo+Pgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEtyenlzenRv ZiBLb3psb3dza2kgPGsua296bG93c2tpQHNhbXN1bmcuY29tPgo+Pj4gLS0tCj4+PiAgZHJpdmVy cy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2dlbS5oIHwgMiAtLQo+Pj4gIDEgZmlsZSBjaGFu Z2VkLCAyIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZXh5bm9zL2V4eW5vc19kcm1fZ2VtLmggYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19k cm1fZ2VtLmgKPj4+IGluZGV4IDMwODE3M2NiNGYwYS4uNmY0MmUyMjQ4Mjg4IDEwMDY0NAo+Pj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2dlbS5oCj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZ2VtLmgKPj4+IEBAIC02MSw3ICs2MSw2 IEBAIHN0cnVjdCBleHlub3NfZHJtX2dlbV9idWYgewo+Pj4gICAqICAgb3IgYXQgZnJhbWVidWZm ZXIgY3JlYXRpb24uCj4+PiAgICogQHNpemU6IHNpemUgcmVxdWVzdGVkIGZyb20gdXNlciwgaW4g Ynl0ZXMgYW5kIHRoaXMgc2l6ZSBpcyBhbGlnbmVkCj4+PiAgICogICBpbiBwYWdlIHVuaXQuCj4+ PiAtICogQHZtYTogYSBwb2ludGVyIHRvIHZtX2FyZWEuCj4+PiAgICogQGZsYWdzOiBpbmRpY2F0 ZSBtZW1vcnkgdHlwZSB0byBhbGxvY2F0ZWQgYnVmZmVyIGFuZCBjYWNoZSBhdHRydWlidXRlLgo+ Pj4gICAqCj4+PiAgICogUC5TLiB0aGlzIG9iamVjdCB3b3VsZCBiZSB0cmFuc2ZlcnJlZCB0byB1 c2VyIGFzIGttc19iby5oYW5kbGUgc28KPj4+IEBAIC03MSw3ICs3MCw2IEBAIHN0cnVjdCBleHlu b3NfZHJtX2dlbV9vYmogewo+Pj4gICAgICAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICAgICAgICAg ICBiYXNlOwo+Pj4gICAgICAgc3RydWN0IGV4eW5vc19kcm1fZ2VtX2J1ZiAgICAgICAqYnVmZmVy Owo+Pj4gICAgICAgdW5zaWduZWQgbG9uZyAgICAgICAgICAgICAgICAgICBzaXplOwo+Pj4gLSAg ICAgc3RydWN0IHZtX2FyZWFfc3RydWN0ICAgICAgICAgICAqdm1hOwo+Pj4gICAgICAgdW5zaWdu ZWQgaW50ICAgICAgICAgICAgICAgICAgICBmbGFnczsKPj4+ICB9Owo+Pj4KPj4+Cj4+Cj4+Cj4+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwo+PiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwKPiAtLQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5k IHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1zYW1zdW5nLXNvYyIgaW4KPiB0aGUgYm9keSBv ZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21v IGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+IAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Fri, 19 Jun 2015 15:03:20 +0900 Subject: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj In-Reply-To: References: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> <5583A87F.5090807@samsung.com> Message-ID: <5583B0A8.3040908@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015? 06? 19? 14:46, Krzysztof Kozlowski wrote: > 2015-06-19 14:28 GMT+09:00 Inki Dae : >> On 2015? 06? 19? 14:23, Krzysztof Kozlowski wrote: >>> The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in >>> 2a3098ff6c21 ("drm/exynos: add userptr feature for g2d module") but is >>> not referenced anywhere. >>> >>> One instance of 'exynos_drm_gem_obj' may be mapped to multiple >>> user-space VMAs so 'vma' field does not look useful anyway. >> >> Krzysztof, >> >> The vma member would be removed by below patch, >> http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html >> > > I think it is a different object. The patch above removes it from > struct g2d_cmdlist_userptr. > However I removed it from struct exynos_drm_gem_obj, where it was > never referenced. Ah, right. There was my mistake. Thanks, Inki Dae > > Best regards, > Krzysztof > >> Thanks, >> Inki Dae >> >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h >>> index 308173cb4f0a..6f42e2248288 100644 >>> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h >>> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h >>> @@ -61,7 +61,6 @@ struct exynos_drm_gem_buf { >>> * or at framebuffer creation. >>> * @size: size requested from user, in bytes and this size is aligned >>> * in page unit. >>> - * @vma: a pointer to vm_area. >>> * @flags: indicate memory type to allocated buffer and cache attruibute. >>> * >>> * P.S. this object would be transferred to user as kms_bo.handle so >>> @@ -71,7 +70,6 @@ struct exynos_drm_gem_obj { >>> struct drm_gem_object base; >>> struct exynos_drm_gem_buf *buffer; >>> unsigned long size; >>> - struct vm_area_struct *vma; >>> unsigned int flags; >>> }; >>> >>> >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel at lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754105AbbFSGDb (ORCPT ); Fri, 19 Jun 2015 02:03:31 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:48161 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbbFSGDW (ORCPT ); Fri, 19 Jun 2015 02:03:22 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79106d00000728c-1a-5583b0a81e86 Content-transfer-encoding: 8BIT Message-id: <5583B0A8.3040908@samsung.com> Date: Fri, 19 Jun 2015 15:03:20 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, Joonyoung Shim , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/exynos: Remove unused vma field of exynos_drm_gem_obj References: <1434691409-9509-1-git-send-email-k.kozlowski@samsung.com> <5583A87F.5090807@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsWyRsSkSHfFhuZQg/unDSx6z51ksrjy9T2b xYt7F1ksXr8wtOh//JrZ4mzTG3aLTY+vsVpc3jWHzWLG+X1MFjMmv2Rz4PLYtKqTzWP7twes Hve7jzN5bF5S79G3ZRWjx+dNcgFsUVw2Kak5mWWpRfp2CVwZJ1ddZS24LVzx+0QnUwPjXf4u Rk4OCQETiZk/vrJD2GISF+6tZ+ti5OIQEljKKLFw3UF2mKLuHTeZIBKLGCX6JmxhBUnwCghK /Jh8j6WLkYODWUBe4silbJAws4C6xKR5i5gh6u8zSux5M50Jol5L4tH2HWA2i4CqxOkHt8EW sAHZE1fcZwOxRQXCJF682sUMYosIGEoc3L0dbDGzwHkmiV0blrKAJIQF/CTuTFrMArFhHaPE /i0vwaZyCgRLrLjczA6SkBD4yC5xo/0R1DoBiW+TD4GdKiEgK7HpADPEa5ISB1fcYJnAKDYL yUOzEB6aheShBYzMqxhFUwuSC4qT0osM9YoTc4tL89L1kvNzNzECo/P0v2e9OxhvH7A+xCjA wajEw/tgfXOoEGtiWXFl7iFGU6AjJjJLiSbnA1NAXkm8obGZkYWpiamxkbmlmZI4r6LUz2Ah gfTEktTs1NSC1KL4otKc1OJDjEwcnFINjJd6Fxfc/upqWXr328njdxb/5vE788/W3eh+q7DG YoaDd/4lqSpavNGb+5l3VrK/306OrPmfec7O0Vd7d27Ft2e3vojqha6/+dbh1d67UnrL79pt TzpXn1q08uiknX2GM6KXT/g/x06vcd32Q8I3oo/0TA1aZ7PygHXwWglpE/4P7Oulypne7LVQ YinOSDTUYi4qTgQA306noskCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42I5/e+xgO6KDc2hBj+OaVn0njvJZHHl63s2 ixf3LrJYvH5haNH/+DWzxdmmN+wWmx5fY7W4vGsOm8WM8/uYLGZMfsnmwOWxaVUnm8f2bw9Y Pe53H2fy2Lyk3qNvyypGj8+b5ALYohoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0t LcyVFPISc1NtlVx8AnTdMnOALlNSKEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAG EtYwZpxcdZW14LZwxe8TnUwNjHf5uxg5OSQETCS6d9xkgrDFJC7cW8/WxcjFISSwiFGib8IW VpAEr4CgxI/J91i6GDk4mAXkJY5cygYJMwuoS0yat4gZov4+o8SeN9OZIOq1JB5t3wFmswio Spx+cJsdxGYDsieuuM8GYosKhEm8eLWLGcQWETCUOLh7OxPIIGaB80wSuzYsZQFJCAv4SdyZ tJgFYsM6Ron9W16CTeUUCJZYcbmZfQKjwCwkB85COHAWkgMXMDKvYhRNLUguKE5KzzXSK07M LS7NS9dLzs/dxAiO/WfSOxhXNVgcYhTgYFTi4X2wvjlUiDWxrLgy9xCjBAezkgjv706gEG9K YmVValF+fFFpTmrxIUZToPcmMkuJJucD01JeSbyhsYmZkaWRuaGFkbG5kjjvyXyfUCGB9MSS 1OzU1ILUIpg+Jg5OqQbGCP+72xOYmDb5mnjW3eC6KpjUeX5iQWePwY6mdmbX55tuS0QfvduV 28Vm7V9ebc8Wqi779cxub+uJCkdvfXa7oW+b1phzM3uWs+MN/eWPJNunv35/2eVj3KbFm2aU v57c1XsvS/7z7CNr/C2fKdeUhLjuYJQrtVbp5p42PeExs/Ihl38TzDcqsRRnJBpqMRcVJwIA 8SOgvBMDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 06월 19일 14:46, Krzysztof Kozlowski wrote: > 2015-06-19 14:28 GMT+09:00 Inki Dae : >> On 2015년 06월 19일 14:23, Krzysztof Kozlowski wrote: >>> The field 'vma' of 'exynos_drm_gem_obj' structure was introduced in >>> 2a3098ff6c21 ("drm/exynos: add userptr feature for g2d module") but is >>> not referenced anywhere. >>> >>> One instance of 'exynos_drm_gem_obj' may be mapped to multiple >>> user-space VMAs so 'vma' field does not look useful anyway. >> >> Krzysztof, >> >> The vma member would be removed by below patch, >> http://lists.freedesktop.org/archives/dri-devel/2015-May/082764.html >> > > I think it is a different object. The patch above removes it from > struct g2d_cmdlist_userptr. > However I removed it from struct exynos_drm_gem_obj, where it was > never referenced. Ah, right. There was my mistake. Thanks, Inki Dae > > Best regards, > Krzysztof > >> Thanks, >> Inki Dae >> >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> drivers/gpu/drm/exynos/exynos_drm_gem.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h >>> index 308173cb4f0a..6f42e2248288 100644 >>> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h >>> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h >>> @@ -61,7 +61,6 @@ struct exynos_drm_gem_buf { >>> * or at framebuffer creation. >>> * @size: size requested from user, in bytes and this size is aligned >>> * in page unit. >>> - * @vma: a pointer to vm_area. >>> * @flags: indicate memory type to allocated buffer and cache attruibute. >>> * >>> * P.S. this object would be transferred to user as kms_bo.handle so >>> @@ -71,7 +70,6 @@ struct exynos_drm_gem_obj { >>> struct drm_gem_object base; >>> struct exynos_drm_gem_buf *buffer; >>> unsigned long size; >>> - struct vm_area_struct *vma; >>> unsigned int flags; >>> }; >>> >>> >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >