All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Azizul Hakim <azizulfahim2002@gmail.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>, alsa-devel@alsa-project.org
Subject: Re: Audio Driver Works In Ubuntu but Crash in Debian	After 2nd Run
Date: Fri, 19 Jun 2015 10:01:02 +0200	[thread overview]
Message-ID: <5583CC3E.1090601@ladisch.de> (raw)
In-Reply-To: <CA+k7Wwb7i5n9dgGGVgkgbOpFC-+tsQnehMgkPLCnOebH5AE4oA@mail.gmail.com>

Azizul Hakim wrote:
> So when a audio playback starts I initialize the buffer pointer to "0"
> in the *.prepare* function.

This is correct.

> https://gist.github.com/azizulhakim/d24a36ef753f9a1536fa
> https://gist.github.com/azizulhakim/b15b002f74e77f88cd5a

This is not; the code confuses bytes and frames.

When in doubt, give _all_ variables a "_bytes" or "_frames" suffix, and
check that _every_ access uses the correct units.


Regards,
Clemens

  parent reply	other threads:[~2015-06-19  8:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14  3:18 Audio Driver Works In Ubuntu but Crash in Debian After 2nd Run Azizul Hakim
2015-06-15 14:26 ` Azizul Hakim
2015-06-16  7:50 ` Clemens Ladisch
2015-06-16 19:30   ` Azizul Hakim
2015-06-17  8:01     ` Clemens Ladisch
2015-06-17  9:05       ` Liam Girdwood
2015-06-17 14:53         ` Azizul Hakim
2015-06-19  4:32           ` Azizul Hakim
2015-06-19  5:56             ` Takashi Sakamoto
2015-06-19  6:21               ` Takashi Sakamoto
2015-06-20  2:52                 ` Takashi Sakamoto
2015-06-19  8:01             ` Clemens Ladisch [this message]
2015-06-21 14:34             ` Raymond Yau
2015-06-22  6:55           ` Peter Ujfalusi
2015-06-22 15:00             ` Azizul Hakim
2015-06-26 14:20               ` Antonio Ospite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5583CC3E.1090601@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=azizulfahim2002@gmail.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.