All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Luca Coelho <luca@coelho.fi>
Cc: <aspriel@gmail.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH py80211] py80211: scan: fix call to _add_scan_attrs() in the sched_scan_start class
Date: Fri, 19 Jun 2015 10:07:14 +0200	[thread overview]
Message-ID: <5583CDB2.3040306@broadcom.com> (raw)
In-Reply-To: <1434439958-9447-1-git-send-email-luca@coelho.fi>

On 06/16/15 09:32, Luca Coelho wrote:
> From: Luciano Coelho<luciano.coelho@intel.com>
>
> We should not pass self explicitly when calling the superclass's
> _add_scan_attrs() in the sched_scan_start class.  Fix it.

Sloppy maintainer at work ;-) My python knowledge need a refresh. I like 
the super() concept, but did not do the training yet. :-)

Thanks for the fix. Applied to py80211 master branch.

Regards,
Arend

> Signed-off-by: Luciano Coelho<luciano.coelho@intel.com>
> ---
>   lib/scan.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/scan.py b/lib/scan.py
> index 32cb68b..3ce242e 100644
> --- a/lib/scan.py
> +++ b/lib/scan.py
> @@ -191,7 +191,7 @@ class sched_scan_start(scan_start_base):
>   		self._matches = None
>
>   	def _add_scan_attrs(self):
> -		super(sched_scan_start, self)._add_scan_attrs(self)
> +		super(sched_scan_start, self)._add_scan_attrs()
>   		if self._interval != None:
>   			nl.nla_put_u32(self._nl_msg._msg, nl80211.ATTR_SCHED_SCAN_INTERVAL, self._interval)
>


      reply	other threads:[~2015-06-19  8:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16  7:32 [PATCH py80211] py80211: scan: fix call to _add_scan_attrs() in the sched_scan_start class Luca Coelho
2015-06-19  8:07 ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5583CDB2.3040306@broadcom.com \
    --to=arend@broadcom.com \
    --cc=aspriel@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.