From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 56018E00A65; Fri, 19 Jun 2015 03:58:53 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.177 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D1458E009D9 for ; Fri, 19 Jun 2015 03:58:51 -0700 (PDT) Received: by wicgi11 with SMTP id gi11so15065447wic.0 for ; Fri, 19 Jun 2015 03:58:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=UCFvkngguZ0+2bSEh7oPlGMboEwgZRjGvyKO/6zPFzc=; b=bxfT5Jo2QRIdpw7lFul44v8tuw5Ln8Fha+ZPHvEfQkq0+7bw7/62U+yCIl7iyKaMVK vN/Wx0oxS7Q7Q4GUCumASyULFJhbRUkvMVjGxau8NRv5a61+C6cQbFPa48Ni3dTskHKS uUHAjomeIJTnCkoWa7GAb7QCzrhZ+Kf3wvFe+9joUz1Y/BOeOlFi1k5slJJ1AH8I9PiK hEfn1vkOFDB3YppVTVwrjb25GfB0c0cW73MIbapMYMyl2ToelqtDWtIrEhWUQBIM4XLs SxR99x0YNvHFUNAZibvitU/vig9ElAQA+Uz9S1kgvY5RUsdrv/yMOUbYRyN/5TG6sdB5 zIfA== X-Gm-Message-State: ALoCoQmIfj63Xvq6fvRVdmzmbqSB0uqVO6HlYy878ohBNmdAwt8HpMoKMD5pPIQN132L3f07mpa6 X-Received: by 10.194.61.180 with SMTP id q20mr23773362wjr.80.1434711530416; Fri, 19 Jun 2015 03:58:50 -0700 (PDT) Received: from [192.168.2.73] ([83.217.123.106]) by mx.google.com with ESMTPSA id k16sm9292680wjr.7.2015.06.19.03.58.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jun 2015 03:58:49 -0700 (PDT) Message-ID: <5583F5E9.1030802@intel.com> Date: Fri, 19 Jun 2015 11:58:49 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: In-Reply-To: Subject: Re: [review-request] adamian/20150603_remove_managed X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 10:58:53 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 17/06/15 17:37, Damian, Alexandru wrote: > Hi, > > This is the first review request for merging of "managed" and > "analysis" modes. > > The branch is here: > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed > Not that familiar with this part of toaster, but noticed a few things: Do you know why the migration generated is so large? http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/diff/bitbake/lib/toaster/orm/migrations/0023_auto__del_field_build_warnings_no__del_field_build_errors_no__del_fiel.py?h=adamian/20150603_remove_managed&id=4d25bdde275293cbecfe7d27ac249ac976210bef Strangely appears to have unmodified tables in there. You have also pushed these commits so I can't currently test the branch. commit 3339d75d6bc1bcfdff50969bc49110b632f28f4a Author: Alexandru DAMIAN Date: Mon Jun 8 11:10:03 2015 +0100 debug versions of js libraries commit b23670f47fc97f7660d6a51f6d6881b94f84d62d Author: Alexandru DAMIAN Date: Tue Jun 9 13:42:09 2015 +0100 enable sentry on icarus.local for debugging Signed-off-by: Alexandru DAMIAN Thanks, Michael > The major changes are: > > - the code paths in templates for "MANAGED" and non-"MANAGED" mode > have been merged, with the MANAGED considered always True > - the interface no longer manipulates BuildRequest objects, only Build > objects; this simplifies the searching, displaying and manipulating > builds. > - the toaster logger has improved error logging, as we can now attach > correct errors to Builds > - in the interactive-command-line mode, all builds go by default to > the Project with id 0. > > What remains to be done is: > > - Bring the UI up to the design, including the capability to create > analysis-only Projects; and the ability to configure the project ID > for interactive command-line builds. > > -- > Alex Damian > Yocto Project > SSG / OTC > >