From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] don't put dom0 console info directly after start_info data Date: Fri, 19 Jun 2015 14:10:06 +0200 Message-ID: <5584069E.3050204@suse.com> References: <1434712013-31328-1-git-send-email-jgross@suse.com> <55842174020000780008703D@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z5v7Y-0002UJ-Vc for xen-devel@lists.xenproject.org; Fri, 19 Jun 2015 12:10:09 +0000 In-Reply-To: <55842174020000780008703D@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: andrew.cooper3@citrix.com, keir@xen.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 06/19/2015 02:04 PM, Jan Beulich wrote: >>>> On 19.06.15 at 13:06, <"jgross@suse.com".non-mime.internet> wrote: >> The console information of dom0 is living in the same memory page as the >> start_info data. Don't put the console data directly after the start_info >> to leave some room for future structure enlargements. Otherwise a dom0 >> with a newer start_info layout than the hypervisor could interprete >> console data as part of the start_info data. >> >> Before commit 50bd1f0825339dfacde471df7664729216fc46e3 there used to be a >> padding at the end of start_info, but this was removed as it was regarded >> to be not necessary. > > Said commit removed padding from shared_info, not start_info. Aargh, not enough coffee, I guess. Sorry for the noise. Juergen