Re: [Qemu-devel] [PATCH v2 1/1] vvfat: add a label option

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]

On 06/19/2015 03:35 AM, Wolfgang Bumiller wrote:
> Until now the vvfat volume label was hardcoded to be
> "QEMU VVFAT", now you can pass a file.label=labelname option
> to the -drive to change it.
> 
> The FAT structure defines the volume label to be limited to
> 11 bytes and is filled up spaces when shorter than that. The
> trailing spaces however aren't exposed to the user by
> operating systems.
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
>  block/vvfat.c        | 25 ++++++++++++++++++++++---
>  qapi/block-core.json |  6 +++++-
>  2 files changed, 27 insertions(+), 4 deletions(-)
> 

> +++ b/qapi/block-core.json
> @@ -1453,13 +1453,17 @@
>  # @fat-type:    #optional FAT type: 12, 16 or 32
>  # @floppy:      #optional whether to export a floppy image (true) or
>  #               partitioned hard disk (false; default)
> +# @label:       #optional set the volume label, limited to 11 bytes. FAT16 and
> +                FAT32 traditionally have some restrictions on labels, which are
> +                ignored by most operating systems. Defaults to "QEMU VVFAT".
> +                (since 2.4)

Nicer; thanks.  (Still doesn't mention what those restrictions are, but
I'm not as worried about that)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]