From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id A218DE00A1A; Fri, 19 Jun 2015 06:51:46 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.53 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 29761E009E1 for ; Fri, 19 Jun 2015 06:51:42 -0700 (PDT) Received: by wgez8 with SMTP id z8so90340841wge.0 for ; Fri, 19 Jun 2015 06:51:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=tFJ7uut62dw2g2C3FbAs6sDBdAM2F25LRmqU6vwgQ3A=; b=SzdbK5jg7rMzs0dXA9LJwN1iXpV+eA1EEUK/s8P8JiqVRJD3Mi5v3D5V5a3kYAgNPs 4dLyGorDtqX8w0YaD/p4IDh+pr76IXevs/ftnHkMV5W4kmu2nnvrvYkjuWRCJ3F42EMy spT3cgOhjMfBHQmggyhfBV9atN7/ZU4/z97BOzrKn0GyRydI4+NBcw0E3PaUen+5dLlh 8qzbW8HU7e7bpzmpLamVjWGQfonOPkS/ltkYOq3DBZ335YHBFxWJNAojEbh12w9IDDFY BR3xNHRKUT+lrVWOWQ5wW5KXueKu7hW93b+u1HoabOngY/oQXM0jB93JN4Y2jXgh235S II1A== X-Gm-Message-State: ALoCoQm6IK3l1UMf9crvAH7wxph6xSqu3kKWInHWBgWPKTYOnN9kGDM6pyKWt/FHfAIPdsNcpEm+ X-Received: by 10.194.79.73 with SMTP id h9mr25495586wjx.125.1434721901435; Fri, 19 Jun 2015 06:51:41 -0700 (PDT) Received: from [192.168.2.73] ([83.217.123.106]) by mx.google.com with ESMTPSA id xa9sm12530099wjc.43.2015.06.19.06.51.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jun 2015 06:51:40 -0700 (PDT) Message-ID: <55841E6C.5040304@intel.com> Date: Fri, 19 Jun 2015 14:51:40 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Damian, Alexandru" References: <5583F5E9.1030802@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] adamian/20150603_remove_managed X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 13:51:46 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 19/06/15 13:29, Damian, Alexandru wrote: > Hi, > > Comments below, > Alex > > On Fri, Jun 19, 2015 at 11:58 AM, Michael Wood > > wrote: > > On 17/06/15 17:37, Damian, Alexandru wrote: > > Hi, > > This is the first review request for merging of "managed" and > "analysis" modes. > > The branch is here: > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150603_remove_managed > > Not that familiar with this part of toaster, but noticed a few things: > > Do you know why the migration generated is so large? > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/diff/bitbake/lib/toaster/orm/migrations/0023_auto__del_field_build_warnings_no__del_field_build_errors_no__del_fiel.py?h=adamian/20150603_remove_managed&id=4d25bdde275293cbecfe7d27ac249ac976210bef > > Strangely appears to have unmodified tables in there. > > > ​The migrations in South are functional, not descriptive. The > migration class has backward() and forward() methods that perform > needed changes on the database schema in backward and forward migrations. > > The "models" contains a complete dump of the current database schema. > This is used when the next migration is made to compute differences > between current database schema and the database schema that is desired. > > > You have also pushed these commits so I can't currently test the > branch. > > commit 3339d75d6bc1bcfdff50969bc49110b632f28f4a > Author: Alexandru DAMIAN > > Date: Mon Jun 8 11:10:03 2015 +0100 > > debug versions of js libraries > > commit b23670f47fc97f7660d6a51f6d6881b94f84d62d > Author: Alexandru DAMIAN > > Date: Tue Jun 9 13:42:09 2015 +0100 > > enable sentry on icarus.local for debugging > > Signed-off-by: Alexandru DAMIAN > > > > These commits should not impede execution - I let them on purposefully > for reviewing, but they are not intended to be submitted upstream; I > hoped to catch errors on Sentry that don't occur during my personal > testing. > > I'll double check to see what errors are you seeing. I'd argue that review needs to be done on what will end up upstream. This is the error with the current branch: 'raven' is not a valid tag library: Template library raven not found, tried django.templatetags.raven,django.contrib.admin.templatetags.raven,django.contrib.staticfiles.templatetags.raven,django.contrib.humanize.templatetags.raven,toastergui.templatetags.raven > > Thanks, > > Michael > > > The major changes are: > > - the code paths in templates for "MANAGED" and non-"MANAGED" > mode have been merged, with the MANAGED considered always True > - the interface no longer manipulates BuildRequest objects, > only Build objects; this simplifies the searching, displaying > and manipulating builds. > - the toaster logger has improved error logging, as we can now > attach correct errors to Builds > - in the interactive-command-line mode, all builds go by > default to the Project with id 0. > > What remains to be done is: > > - Bring the UI up to the design, including the capability to > create analysis-only Projects; and the ability to configure > the project ID for interactive command-line builds. > > -- > Alex Damian > Yocto Project > SSG / OTC > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >