Re: [Devel] ACPICA version 20150619 released

[Dean Nelson <dnelson at redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

On 06/19/2015 09:15 AM, Moore, Robert wrote:
> 19 June 2015. Summary of changes for version 20150619:
>
> This release is available at https://acpica.org/downloads

Please excuse my ignorance, but why are the download files named
*.tar_0.gz ? Why the '_0' ?

Also I noticed that the git-repo with the latest commit being...

   commit d7a940bb308d001b5d2b196174fee36c7daa61d6
   Author:     Robert Moore <Robert.Moore(a)intel.com>
   AuthorDate: Thu Jun 18 08:13:39 2015 -0700
   Commit:     Robert Moore <Robert.Moore(a)intel.com>
   CommitDate: Thu Jun 18 08:13:39 2015 -0700
       Update version to 20150619.

differs from the two source code tarballs with regard to
source/compiler/asllookup.c by the git-diff file that I've
attached. But I don't see that patch mentioned in the git-repo.
So where did those changes come from? And do they really belong
in the tarballs? And if yes, why aren't they in the git-repo?

Thanks,
Dean


>
> Two regressions in version 20150616 have been addressed:
>
> Fixes some problems/issues with the C library macro removal (ACPI_STRLEN, etc.)
> This update changes ACPICA to only use the standard headers for functions, or
> (optionally) the local prototypes for the local versions of the C library functions.
> Across the source code, this required some additional casts for some Clib invocations
> for portability. Moved all local prototypes to a new file, acclib.h
>
> Fixes several problems with recent changes to the handling of the FACS table that
> could cause some systems not to boot.
>
>
> _______________________________________________
> Devel mailing list
> Devel(a)acpica.org
> https://lists.acpica.org/mailman/listinfo/devel
>


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: difference.patch --]
[-- Type: text/x-patch, Size: 1448 bytes --]

diff --git a/source/compiler/asllookup.c b/source/compiler/asllookup.c
index 4a7539a..9c60d03 100644
--- a/source/compiler/asllookup.c
+++ b/source/compiler/asllookup.c
@@ -181,6 +181,13 @@ LkFindUnreferencedObjects (
  *              if they are not referenced.
  *
  ******************************************************************************/
+typedef struct asl_method_local
+{
+    UINT32                  Flags;
+    ACPI_PARSE_OBJECT       *Op;
+
+} ASL_METHOD_LOCAL;
+
 
 static ACPI_STATUS
 LkIsObjectUsed (
@@ -191,6 +198,8 @@ LkIsObjectUsed (
 {
     ACPI_NAMESPACE_NODE     *Node = ACPI_CAST_PTR (ACPI_NAMESPACE_NODE, ObjHandle);
     ACPI_NAMESPACE_NODE     *Next;
+    ASL_METHOD_LOCAL        *MethodLocals;
+    UINT32                  i;
 
 
     /* Referenced flag is set during the namespace xref */
@@ -217,6 +226,24 @@ LkIsObjectUsed (
 
         return (AE_OK);
 
+    case ACPI_TYPE_METHOD:
+
+        /* Check for Locals that are set but never used */
+
+        MethodLocals = (ASL_METHOD_LOCAL *) Node->Object;
+        for (i = 0; i < ACPI_METHOD_NUM_LOCALS; i++)
+        {
+            if (MethodLocals[i].Flags & ANOBJ_IS_REFERENCED)
+            {
+                sprintf (MsgBuffer, "Local%u",
+                    i);
+
+                AslError (ASL_REMARK, ASL_MSG_LOCAL_NOT_USED,
+                    MethodLocals[i].Op, MsgBuffer);
+            }
+        }
+        break;
+
     default:
 
         break;