From: Declan Doherty <declan.doherty@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [PATCH 2/2] bonding: fix name and port validation
Date: Fri, 19 Jun 2015 16:52:28 +0100 [thread overview]
Message-ID: <55843ABC.6020606@intel.com> (raw)
In-Reply-To: <1433973985-17940-3-git-send-email-stephen@networkplumber.org>
On 10/06/15 23:06, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> Cleanup the code in bonding that checks ports.
> * Use standard rte_eth_dev_is_valid_port
> * Change name of driver string to avoid variable namespace conflicts
> * Get rid of unnecessary string comparison stuff. A simple pointer
> check is enough here.
> * Get rid of unnecessary assignment of driver_name, it is already
> done by common code.
> * Don't generate unnecessary log messages on error.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2015-06-19 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 22:06 [PATCH 0/2] Trivial bonding patches Stephen Hemminger
2015-06-10 22:06 ` [PATCH 1/2] ethdev: make rte_eth_dev_is_valid_port public Stephen Hemminger
2015-06-11 9:13 ` Bruce Richardson
2015-06-10 22:06 ` [PATCH 2/2] bonding: fix name and port validation Stephen Hemminger
2015-06-19 15:52 ` Declan Doherty [this message]
2015-07-20 0:32 ` [PATCH 0/2] Trivial bonding patches Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55843ABC.6020606@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.