On 06/19/2015 09:15 AM, Andreas Färber wrote: > Am 27.05.2015 um 17:07 schrieb Daniel P. Berrange: >> Now that properties can be explicitly registered as an enum >> type, there is no need to pass the string table to the >> object_get_enum method. The object property registration >> already has a pointer to the string table. >> >> In changing this method signature, the hostmem backend object >> has to be converted to use the new enum property registration >> code, which simplifies it somewhat. >> >> Signed-off-by: Daniel P. Berrange >> --- >> backends/hostmem.c | 22 ++++++++-------------- >> include/qom/object.h | 4 ++-- >> numa.c | 2 +- >> qom/object.c | 19 +++++++++++++++++-- >> tests/check-qom-proplist.c | 43 +++++++++++++++++++++++++++++++++++++++++++ >> 5 files changed, 71 insertions(+), 19 deletions(-) > > There's been no protest after it appeared in v4, so I'm applying it for > my v3 pull. If anyone has objections, please speak up now. I pointed out a couple of minor issues, but they are not showstoppers, so you can add to the series: Reviewed-by: Eric Blake -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org