From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754614AbbFSQPq (ORCPT ); Fri, 19 Jun 2015 12:15:46 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:34417 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753358AbbFSQPj (ORCPT ); Fri, 19 Jun 2015 12:15:39 -0400 Message-ID: <55844029.5090002@kernel.dk> Date: Fri, 19 Jun 2015 10:15:37 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Vladimir Zapolskiy CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: cfq-iosched: fix unused 'cpd_to_cfqgd' function warning References: <1434666793-13339-1-git-send-email-vz@mleia.com> In-Reply-To: <1434666793-13339-1-git-send-email-vz@mleia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2015 04:33 PM, Vladimir Zapolskiy wrote: > If CFQ_GROUP_IOSCHED kernel option is not set, a compiler produces the > following warning: > > CC block/cfq-iosched.o > linux/block/cfq-iosched.c:469:2: > warning: 'cpd_to_cfqgd' defined but not used [-Wunused-function] > *cpd_to_cfqgd(struct blkcg_policy_data *cpd) > ^ > > Define this function only if CFQ_GROUP_IOSCHED is set and remove > the compilation warning. The two other related functions aren't used either if group scheduling isn't enabled. I committed this instead: http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.2/core&id=4ceab71b9d84e55b59a76b54b2999dc377aae6e6 -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/