All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jakub Narębski" <jnareb@gmail.com>
To: Tuncer Ayaz <tuncer.ayaz@gmail.com>, Theodore Ts'o <tytso@mit.edu>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>
Subject: Re: co-authoring commits
Date: Fri, 19 Jun 2015 20:18:38 +0200	[thread overview]
Message-ID: <55845CFE.4070407@gmail.com> (raw)
In-Reply-To: <CAOvwQ4jb-w4+Ah3ZhVE0j1aXLx1=8tRN3Wo98tz+G-wEqLGAcA@mail.gmail.com>

On 2015-06-18 at 23:25, Tuncer Ayaz wrote:
> On Thu, Jun 18, 2015 at 12:52 AM, Theodore Ts'o wrote:
>> On Wed, Jun 17, 2015 at 10:26:32PM +0200, Tuncer Ayaz wrote:
[...]
>> One could imagine some frankly, quite rare example where there is a
>> team of people who votes on each commit before it gets sent out and
>> where everyone is equal and there is no hierarchy. In that case,
>> perhaps you could set the from field to a mailing list address. But
>> honestly, how often is that *all* of the authors are completely
>> equal[1]?
> 
> For that case something like patchwork, phabricator, or gerrit seems
> to be the logical tool to use, and should ideally leave a trace of
> approvals and such in the resulting commit message(s). If the patch
> management tool takes care of merging the commit(s), it can be harder
> to misattribute signed-off/reviewed-by/etc, which is a good thing.

Doesn't Gerrit (at least) use trailer-like structured *notes* in the
'reviews' category (i.e. refs/notes/reviews ref) to store information
about review process?

> You could of course use multiple (everybody makes their own) commits,
> where you risk breaking bisectability and avoid the need for equal
> co-authorship support. In pair programming such intermediate commits
> will quite often be fixups, and when you attempt to squash the fixups
> for bisectability's sake, you may get a desire for co-authorship of
> the resulting commit.

Hmmm... I didn't think about the problem of attributing authorship
for squashed commits.  Though here multiple 'author' headers, or
multiline 'author' header would be a better match than 'coauthor'
header (which itself doesn't need, I think, the date filed, or does it?)

[This is sent from Thunderbird news, so it should be all right]
-- 
Jakub Narębski

  reply	other threads:[~2015-06-19 18:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 19:52 co-authoring commits Tuncer Ayaz
2015-06-17 19:58 ` Junio C Hamano
2015-06-17 20:26   ` Tuncer Ayaz
2015-06-17 20:57     ` Junio C Hamano
2015-06-17 21:17       ` josh
2015-06-17 20:59     ` josh
2015-06-17 21:51       ` Junio C Hamano
2015-06-17 22:07         ` Tuncer Ayaz
2015-06-17 22:28         ` josh
2015-06-17 22:44           ` Junio C Hamano
2015-06-18 21:25             ` Jakub Narębski
2015-06-19  4:25               ` Jeff King
2015-06-19 18:02                 ` Jakub Narębski
2015-06-17 22:52     ` Theodore Ts'o
2015-06-17 23:06       ` josh
2015-06-18 10:54       ` Jason Pyeron
2015-06-18 21:25       ` Tuncer Ayaz
2015-06-19 18:18         ` Jakub Narębski [this message]
2015-06-19 21:11           ` Tuncer Ayaz
2015-06-19 21:25             ` Jakub Narębski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55845CFE.4070407@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=josh@joshtriplett.org \
    --cc=tuncer.ayaz@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.