Re: [Powertop] [powertop] Indicate that the <tab> key is to use to navigate in the application (#19)

Re: [Powertop] [powertop] Indicate that the <tab> key is to use to navigate in the application (#19)

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Hi Pierre,


> This makes is explicit how to leave or navigate in the program from the
> front
> page. It changes one string for the translators.
>
> Fixes https://bugzilla.redhat.com/1191112
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/fenrus75/powertop/pull/19
>
> -- Commit Summary --
>
>   * Indicate that the <tab> key is to use to navigate in the application
>
> -- File Changes --
>
>     M src/display.cpp (2)
>
> -- Patch Links --
>
> https://github.com/fenrus75/powertop/pull/19.patch
> https://github.com/fenrus75/powertop/pull/19.diff
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fenrus75/powertop/pull/19
>


Your patches add compilation Errors to PowerTOP.

 CXX      powertop-display.o
display.cpp: In function ‘void show_tab(unsigned int)’:
display.cpp:132:44: error: expected ‘;’ before ‘)’ token
                   _("Exit"), _("Navigate")));
                                            ^
make[3]: *** [powertop-display.o] Error 1
make[3]: Leaving directory `/home/magt/git/powertop/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/magt/git/powertop/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/magt/git/powertop'
make: *** [all] Error 2


Also please send your patches directly to the mailing list.  This gives
the list the ability to review your contributions.

Thank you,
Alexandra.

Re: [Powertop] [powertop] Indicate that the <tab> key is to use to navigate in the application (#19)

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Pierre,

> @magnoliatitanium Hi Alexandra,
>
> Sorry about the error, a one-too-many bracket. It is removed now.
>
> I saw the instruction about the mailing list but I am not subscribed there
> thus my asking to the Fedora maintainer (in the bugzilla ticket) to bring
> this change to upstream/you.
> I hope this is fine with you.
>
> Note: I can merge all the commits into one if you prefer.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/fenrus75/powertop/pull/19#issuecomment-76245739

Unfortunately, I can't go around the process that is already in place. I
can't go around accepting patches without the mailing list's established
curating process.

Please be considerate with your fellow contributors and send the patches
following the standard process.

Thank you,
Alexandra.