From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/3] rcar_can: print signed IRQ # Date: Sat, 20 Jun 2015 17:38:11 +0300 Message-ID: <55857AD3.4040000@cogentembedded.com> References: <2010452.WyFito6egU@wasted.cogentembedded.com> <2390389.thI8mIvbv5@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lb0-f172.google.com ([209.85.217.172]:35890 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754125AbbFTOiP (ORCPT ); Sat, 20 Jun 2015 10:38:15 -0400 Received: by lbbqq2 with SMTP id qq2so86683523lbb.3 for ; Sat, 20 Jun 2015 07:38:14 -0700 (PDT) In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: "netdev@vger.kernel.org" , wg@grandegger.com, Marc Kleine-Budde , linux-can@vger.kernel.org, Linux-sh list Hello. On 6/20/2015 3:03 PM, Geert Uytterhoeven wrote: >> Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as >> 'ndev->irq' is of type *int*, so the "%d" format needs to be used instead. >> While fixing this, beautify the dev_info() message in rcar_can_probe() a bit. > If you change the message, why don't you make it consistent > ("interrupt" vs. "IRQ")? I decided to change the message in a follow-up patch (posted afterwards). >> Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver") >> Signed-off-by: Sergei Shtylyov [...] > Gr{oetje,eeting}s, > Geert WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-can" in From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sat, 20 Jun 2015 14:38:11 +0000 Subject: Re: [PATCH 2/3] rcar_can: print signed IRQ # Message-Id: <55857AD3.4040000@cogentembedded.com> List-Id: References: <2010452.WyFito6egU@wasted.cogentembedded.com> <2390389.thI8mIvbv5@wasted.cogentembedded.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: "netdev@vger.kernel.org" , wg@grandegger.com, Marc Kleine-Budde , linux-can@vger.kernel.org, Linux-sh list Hello. On 6/20/2015 3:03 PM, Geert Uytterhoeven wrote: >> Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as >> 'ndev->irq' is of type *int*, so the "%d" format needs to be used instead. >> While fixing this, beautify the dev_info() message in rcar_can_probe() a bit. > If you change the message, why don't you make it consistent > ("interrupt" vs. "IRQ")? I decided to change the message in a follow-up patch (posted afterwards). >> Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver") >> Signed-off-by: Sergei Shtylyov [...] > Gr{oetje,eeting}s, > Geert WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in