From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2994840955742658574==" MIME-Version: 1.0 From: Alexandra Yates Subject: Re: [Powertop] Powertop crashes with 'powertop --auto-tune' Date: Wed, 28 Jan 2015 15:38:31 -0800 Message-ID: <55859.10.24.4.75.1422488311.squirrel@linux.intel.com> In-Reply-To: df44fda28c5657fc5c7d58cef333ae45@smtp.hushmail.com To: powertop@lists.01.org List-ID: --===============2994840955742658574== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > I did not see your change before I posted the patch below. However, I do > see it now. > https://lists.01.org/pipermail/powertop/2014-December/001730.html > > Joerg found it first. Please take my patch as a verification of his. > > On 01/22/2015 06:32 PM, Joerg Mayer wrote: >> Hmm, it looks like nobody reacted to (and thus duplicated the work of): >> >> Date: Mon, 22 Dec 2014 02:27:26 +0100 From: Joerg Mayer >> To: powertop(a)ml01.01.org In-Reply-To: <549762B4.3090108(a)linux.intel.= com> >> >> Which contains the first part of the patch (the one causing the crash) >> but not the second (which isn't *strictly* required but makes sense from >> a "good style" point of view). >> >> Did anyone but me actually see that message? I verified that I did >> receive it back via the list (receive headers). >> >> Thanks J=C3=83=C2=B6rg >> >> On Thu, Jan 22, 2015 at 04:50:10PM -0500, Michael Mullin wrote: Please >> see the following patch to address the reported crash --- From >> e994a414f619410877023fce35ade12d1cfce68d Mon Sep 17 00:00:00 2001 From: >> Michael Mullin Date: Thu, 22 Jan 2015 16:33:31 >> -0500 Subject: [PATCH] If "dir" is closed early inside >> create_add_devfreq_devices() then there is a potential double free due >> to a second close during the cleanup phase in clear_all_devfreq() >> >> Signed-off-by: Michael Mullin >> >> --- src/devices/devfreq.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 >> deletion(-) >> >> diff --git a/src/devices/devfreq.cpp b/src/devices/devfreq.cpp index >> d2e56e3..f652a57 100644 --- a/src/devices/devfreq.cpp +++ >> b/src/devices/devfreq.cpp @@ -247,6 +247,7 @@ void >> create_all_devfreq_devices(void) fprintf(stderr, "Devfreq not >> enabled\n"); is_enabled =3D false; closedir(dir); + dir =3D NULL; retur= n; } >> >> @@ -327,6 +328,8 @@ void clear_all_devfreq() } all_devfreq.clear(); /* >> close /sys/class/devfreq */ - if (dir !=3D NULL) + if (dir !=3D NULL) { >> closedir(dir); + dir =3D NULL; + } } >>> >>> _______________________________________________ PowerTop mailing list >>> PowerTop(a)lists.01.org https://lists.01.org/mailman/listinfo/powertop >> > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQEcBAEBCAAGBQJUwYsGAAoJEJHz7fmWOTHsKyAH/jlGevaIUil2FlGvkkGo4Y+U > xeQNfkVKQbtzpvYW8jKvp+3e08AfNpZIfHrhcholOA9YimV4QDCTLeMc56L89IIZ > CF1xXf+Li09cb9d52sdctHhwGuGAr9a951HqSumns3uyFVjYkhLDvrJQajOBONaI > m+h7qffm6R3VkBfieTHEAw+ywp74aVK5jnGeZGK/z2R2w2LE6aFR0tM2ABvUFARL > XenaceU0rFBYiSHd8LipKX4Y/qC3Nk0ExSGMMnXuLZ/pZ304wmogwqpT1ccr7s4n > iSFj+Jo3xYyW2OgceL/kw8N9V4kG4P6wXn1ACRX1Uo09ACsMCEcnx0xWopunpiU=3D > =3D0HBf > -----END PGP SIGNATURE----- > > _______________________________________________ > PowerTop mailing list > PowerTop(a)lists.01.org > https://lists.01.org/mailman/listinfo/powertop > All, Big apologies, I though I added Joerg's patch to upstream in December. = I've added Michael's now, to include all changes. I would appreciate if you confirm that upstream is fixed now. I will add a new release after the test are confirmed to work. Thank you, Alexandra. --===============2994840955742658574==--