From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support
Date: Sat, 20 Jun 2015 23:13:39 +0200 [thread overview]
Message-ID: <5585D783.5050405@redhat.com> (raw)
In-Reply-To: <1434113861-26495-17-git-send-email-stefanha@redhat.com>
On 12/06/2015 14:57, Stefan Hajnoczi wrote:
> + RockerSwitch *rocker = g_malloc0(sizeof(*rocker));
> + Rocker *r;
> +
> + r = rocker_find(name);
> + if (!r) {
> + error_set(errp, ERROR_CLASS_GENERIC_ERROR,
> + "rocker %s not found", name);
> + return NULL;
Memory leak, please initialize rocker after the "if".
Paolo
> + }
> +
> + rocker->name = g_strdup(r->name);
next prev parent reply other threads:[~2015-06-20 21:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 12:57 [Qemu-devel] [PULL 00/16] Net patches Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 01/16] stubs: Add qemu_set_fd_handler Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 02/16] l2tpv3: Drop l2tpv3_can_send Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 03/16] netmap: Drop netmap_can_send Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 04/16] net/socket: Drop net_socket_can_send Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 05/16] tap: Drop tap_can_send Stefan Hajnoczi
2015-07-09 22:42 ` Aurelien Jarno
2015-06-12 12:57 ` [Qemu-devel] [PULL 06/16] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 07/16] main-loop: Drop qemu_set_fd_handler2 Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 08/16] alsaaudio: Remove unused error handling of qemu_set_fd_handler Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 09/16] oss: " Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 10/16] xen_backend: " Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 11/16] event-notifier: Always return 0 for posix implementation Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 12/16] iohandler: Change return type of qemu_set_fd_handler to "void" Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 13/16] rocker: Add support for phys name Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 14/16] rocker: update tests using hw-derived interface names Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 15/16] rocker: bring link up/down on PHY enable/disable Stefan Hajnoczi
2015-06-12 12:57 ` [Qemu-devel] [PULL 16/16] qmp/hmp: add rocker device support Stefan Hajnoczi
2015-06-20 21:13 ` Paolo Bonzini [this message]
2015-06-12 17:03 ` [Qemu-devel] [PULL 00/16] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5585D783.5050405@redhat.com \
--to=pbonzini@redhat.com \
--cc=jiri@resnulli.us \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sfeldma@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.