From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Kevin Tsai <ktsai@capellamicro.com>,
Daniel Baluta <daniel.baluta@intel.com>
Subject: Re: [PATCH v2 6/7] iio:light:cm3323: make use of GENMASK
Date: Sun, 21 Jun 2015 14:28:36 +0100 [thread overview]
Message-ID: <5586BC04.8010301@kernel.org> (raw)
In-Reply-To: <4c312fabbb090163d1b071e489441e3d02a842dd.1434578207.git.knaack.h@gmx.de>
On 17/06/15 23:32, Hartmut Knaack wrote:
> Use GENMASK to define the integration time bitmask.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
Applied
> ---
> drivers/iio/light/cm3323.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c
> index 2c49ec2..1fc9f78 100644
> --- a/drivers/iio/light/cm3323.c
> +++ b/drivers/iio/light/cm3323.c
> @@ -29,7 +29,7 @@
>
> #define CM3323_CONF_SD_BIT BIT(0) /* sensor disable */
> #define CM3323_CONF_AF_BIT BIT(1) /* auto/manual force mode */
> -#define CM3323_CONF_IT_MASK (BIT(4) | BIT(5) | BIT(6))
> +#define CM3323_CONF_IT_MASK GENMASK(6, 4)
> #define CM3323_CONF_IT_SHIFT 4
>
> #define CM3323_INT_TIME_AVAILABLE "0.04 0.08 0.16 0.32 0.64 1.28"
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
next prev parent reply other threads:[~2015-06-21 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 22:31 [PATCH v2 0/7] cm3323 fixes and cleanups Hartmut Knaack
2015-06-17 22:31 ` [PATCH v2 1/7] iio:light:cm3323: clear bitmask before set Hartmut Knaack
2015-06-21 13:25 ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 2/7] iio:light:Kconfig: fix typo in description Hartmut Knaack
2015-06-21 13:26 ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 3/7] iio:light:cm3323: pass up error value Hartmut Knaack
2015-06-21 13:27 ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 4/7] iio:light:cm3323: drop barely used variable Hartmut Knaack
2015-06-17 22:32 ` [PATCH v2 5/7] iio:light:cm3323: replace unneeded variable Hartmut Knaack
2015-06-21 13:27 ` Jonathan Cameron
2015-06-17 22:32 ` [PATCH v2 6/7] iio:light:cm3323: make use of GENMASK Hartmut Knaack
2015-06-21 13:28 ` Jonathan Cameron [this message]
2015-06-17 22:32 ` [PATCH v2 7/7] iio:light:cm3323: add empty lines for code structure Hartmut Knaack
2015-06-21 13:28 ` Jonathan Cameron
2015-06-21 13:19 ` [PATCH v2 0/7] cm3323 fixes and cleanups Jonathan Cameron
2015-06-21 13:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5586BC04.8010301@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.