Re: [PATCH] iio: light: tcs3414: Fix bug preventing to set integration time

[Jonathan Cameron <jic23@kernel.org>]

On 14/06/15 22:09, Peter Meerwald wrote:
> the millisecond values in tcs3414_times should be checked against
> val2, not val, which is always zero.
> 
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Reported-by: Stephan Kleisinger <stephan.kleisinger@gmail.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan
> ---
>  drivers/iio/light/tcs3414.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c
> index 71c2bde..f8b1df0 100644
> --- a/drivers/iio/light/tcs3414.c
> +++ b/drivers/iio/light/tcs3414.c
> @@ -185,7 +185,7 @@ static int tcs3414_write_raw(struct iio_dev *indio_dev,
>  		if (val != 0)
>  			return -EINVAL;
>  		for (i = 0; i < ARRAY_SIZE(tcs3414_times); i++) {
> -			if (val == tcs3414_times[i] * 1000) {
> +			if (val2 == tcs3414_times[i] * 1000) {
>  				data->timing &= ~TCS3414_INTEG_MASK;
>  				data->timing |= i;
>  				return i2c_smbus_write_byte_data(
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in