From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 1/2] xen{trace/analyze}: don't use 64bit versions of libc functions Date: Mon, 22 Jun 2015 10:08:36 +0100 Message-ID: <5587D094.9030304@eu.citrix.com> References: <1434704305-64692-1-git-send-email-roger.pau@citrix.com> <1434704305-64692-2-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z6xj2-0001a2-4r for xen-devel@lists.xenproject.org; Mon, 22 Jun 2015 09:09:08 +0000 In-Reply-To: <1434704305-64692-2-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Wei Liu , Olaf Hering , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org T24gMDYvMTkvMjAxNSAwOTo1OCBBTSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+IFRoaXMgaXMg bm90IG5lZWRlZCwgbmVpdGhlciBlbmNvdXJhZ2VkLiBDb25maWd1cmUgYWxyZWFkeSBjaGVja3MK PiBfRklMRV9PRkZTRVRfQklUUyBhbmQgYXBwZW5kcyBpdCB3aGVuIG5lZWRlZCwgc28gdGhhdCB0 aGUgcmlnaHQgZnVuY3Rpb25zCj4gYXJlIHVzZWQuIEFsc28gcmVtb3ZlIHRoZSB1c2FnZSBvZiBs b2ZmX3QgYW5kIE9fTEFSR0VGSUxFIGZvciB0aGUgc2FtZQo+IHJlYXNvbi4KCkp1c3Qgc28gSSB1 bmRlcnN0YW5kIC0tIGFyZSB5b3Ugc2F5aW5nIHRoYXQgY29uZmlndXJlIGF0IHRoZSB0b29scwpk aXJlY3RvcnkgbGV2ZWwgd2lsbCBub3RpY2UgdGhhdCBMaW51eCBjYW4gaGFuZGxlIDY0LWJpdCBm aWxlIG9wZXJhdGlvbnMKYW5kIHVzZSB0aGVtIGF1dG9tYXRpY2FsbHk/CgogLUdlb3JnZQoKPiAK PiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K PiBDYzogR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBldS5jaXRyaXguY29tPgo+IENjOiBJ YW4gSmFja3NvbiA8aWFuLmphY2tzb25AZXUuY2l0cml4LmNvbT4KPiBDYzogSWFuIENhbXBiZWxs IDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KPiBDYzogV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4 LmNvbT4KPiBDYzogT2xhZiBIZXJpbmcgPG9sYWZAYWVwZmxlLmRlPgo+IC0tLQo+ICB0b29scy94 ZW50cmFjZS9tcmVhZC5jICAgIHwgIDggKysrKy0tLS0KPiAgdG9vbHMveGVudHJhY2UvbXJlYWQu aCAgICB8ICA2ICsrKy0tLQo+ICB0b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jIHwgMjggKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMo KyksIDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90b29scy94ZW50cmFjZS9tcmVh ZC5jIGIvdG9vbHMveGVudHJhY2UvbXJlYWQuYwo+IGluZGV4IGE2M2QxNmMuLmEyMmM0ZWEgMTAw NjQ0Cj4gLS0tIGEvdG9vbHMveGVudHJhY2UvbXJlYWQuYwo+ICsrKyBiL3Rvb2xzL3hlbnRyYWNl L21yZWFkLmMKPiBAQCAtOSw3ICs5LDcgQEAKPiAgCj4gIG1yZWFkX2hhbmRsZV90IG1yZWFkX2lu aXQoaW50IGZkKQo+ICB7Cj4gLSAgICBzdHJ1Y3Qgc3RhdDY0IHM7Cj4gKyAgICBzdHJ1Y3Qgc3Rh dCBzOwo+ICAgICAgbXJlYWRfaGFuZGxlX3QgaDsKPiAgICAgIAo+ICAgICAgaD1tYWxsb2Moc2l6 ZW9mKHN0cnVjdCBtcmVhZF9jdHJsKSk7Cj4gQEAgLTI0LDEzICsyNCwxMyBAQCBtcmVhZF9oYW5k bGVfdCBtcmVhZF9pbml0KGludCBmZCkKPiAgCj4gICAgICBoLT5mZCA9IGZkOwo+ICAKPiAtICAg IGZzdGF0NjQoZmQsICZzKTsKPiArICAgIGZzdGF0KGZkLCAmcyk7Cj4gICAgICBoLT5maWxlX3Np emUgPSBzLnN0X3NpemU7Cj4gIAo+ICAgICAgcmV0dXJuIGg7Cj4gIH0KPiAgCj4gLXNzaXplX3Qg bXJlYWQ2NChtcmVhZF9oYW5kbGVfdCBoLCB2b2lkICpyZWMsIHNzaXplX3QgbGVuLCBsb2ZmX3Qg b2Zmc2V0KQo+ICtzc2l6ZV90IG1yZWFkNjQobXJlYWRfaGFuZGxlX3QgaCwgdm9pZCAqcmVjLCBz c2l6ZV90IGxlbiwgb2ZmX3Qgb2Zmc2V0KQo+ICB7Cj4gICAgICAvKiBJZGVhOiBoYXZlIGEgImNh Y2hlIiBvZiBOIG1tYXBlZCByZWdpb25zLiAgSWYgdGhlIG9mZnNldCBpcwo+ICAgICAgICogaW4g b25lIG9mIHRoZSByZWdpb25zLCBqdXN0IGNvcHkgaXQuICBJZiBub3QsIGV2aWN0IG9uZSBvZiB0 aGUKPiBAQCAtNDUsNyArNDUsNyBAQCBzc2l6ZV90IG1yZWFkNjQobXJlYWRfaGFuZGxlX3QgaCwg dm9pZCAqcmVjLCBzc2l6ZV90IGxlbiwgbG9mZl90IG9mZnNldCkKPiAgICAgICAqLwo+ICAgICAg Y2hhciAqIGI9TlVMTDsKPiAgICAgIGludCBiaW5kPS0xOwo+IC0gICAgbG9mZl90IGJvZmZzZXQ9 MDsKPiArICAgIG9mZl90IGJvZmZzZXQ9MDsKPiAgICAgIHNzaXplX3QgYnNpemU7Cj4gIAo+ICAj ZGVmaW5lIGRwcmludGYoeC4uLikKPiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVudHJhY2UvbXJlYWQu aCBiL3Rvb2xzL3hlbnRyYWNlL21yZWFkLmgKPiBpbmRleCA4ZGY0MWE4Li40NDM4MTRmIDEwMDY0 NAo+IC0tLSBhL3Rvb2xzL3hlbnRyYWNlL21yZWFkLmgKPiArKysgYi90b29scy94ZW50cmFjZS9t cmVhZC5oCj4gQEAgLTUsMTQgKzUsMTQgQEAKPiAgI2RlZmluZSBNUkVBRF9CVUZfTUFTSyAofihN UkVBRF9CVUZfU0laRS0xKSkKPiAgdHlwZWRlZiBzdHJ1Y3QgbXJlYWRfY3RybCB7Cj4gICAgICBp bnQgZmQ7Cj4gLSAgICBsb2ZmX3QgZmlsZV9zaXplOwo+ICsgICAgb2ZmX3QgZmlsZV9zaXplOwo+ ICAgICAgc3RydWN0IG1yZWFkX2J1ZmZlciB7Cj4gICAgICAgICAgY2hhciAqIGJ1ZmZlcjsKPiAt ICAgICAgICBsb2ZmX3Qgc3RhcnRfb2Zmc2V0Owo+ICsgICAgICAgIG9mZl90IHN0YXJ0X29mZnNl dDsKPiAgICAgICAgICBpbnQgYWNjZXNzZWQ7Cj4gICAgICB9IG1hcFtNUkVBRF9NQVBTXTsKPiAg ICAgIGludCBjbG9jaywgbGFzdDsKPiAgfSAqbXJlYWRfaGFuZGxlX3Q7Cj4gIAo+ICBtcmVhZF9o YW5kbGVfdCBtcmVhZF9pbml0KGludCBmZCk7Cj4gLXNzaXplX3QgbXJlYWQ2NChtcmVhZF9oYW5k bGVfdCBoLCB2b2lkICpkc3QsIHNzaXplX3QgbGVuLCBsb2ZmX3Qgb2Zmc2V0KTsKPiArc3NpemVf dCBtcmVhZDY0KG1yZWFkX2hhbmRsZV90IGgsIHZvaWQgKmRzdCwgc3NpemVfdCBsZW4sIG9mZl90 IG9mZnNldCk7Cj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnRyYWNlL3hlbmFseXplLmMgYi90b29s cy94ZW50cmFjZS94ZW5hbHl6ZS5jCj4gaW5kZXggYThlNzNlYi4uZGM4OWZmZSAxMDA2NDQKPiAt LS0gYS90b29scy94ZW50cmFjZS94ZW5hbHl6ZS5jCj4gKysrIGIvdG9vbHMveGVudHJhY2UveGVu YWx5emUuYwo+IEBAIC03MCw5ICs3MCw5IEBAIHN0cnVjdCB7Cj4gICAgICBjaGFyICogc3ltYm9s X2ZpbGU7Cj4gICAgICBjaGFyICogdHJhY2VfZmlsZTsKPiAgICAgIGludCBvdXRwdXRfZGVmaW5l ZDsKPiAtICAgIGxvZmZfdCBmaWxlX3NpemU7Cj4gKyAgICBvZmZfdCBmaWxlX3NpemU7Cj4gICAg ICBzdHJ1Y3Qgewo+IC0gICAgICAgIGxvZmZfdCB1cGRhdGVfb2Zmc2V0Owo+ICsgICAgICAgIG9m Zl90IHVwZGF0ZV9vZmZzZXQ7Cj4gICAgICAgICAgaW50IHBpcGVbMl07Cj4gICAgICAgICAgRklM RSogb3V0Owo+ICAgICAgICAgIGludCBwaWQ7Cj4gQEAgLTE4NTMsOCArMTg1Myw4IEBAIHN0cnVj dCBwY3B1X2luZm8gewo+ICAKPiAgICAgIC8qIEluZm9ybWF0aW9uIHJlbGF0ZWQgdG8gc2Nhbm5p bmcgdGhydSB0aGUgZmlsZSAqLwo+ICAgICAgdHNjX3QgZmlyc3RfdHNjLCBsYXN0X3RzYywgb3Jk ZXJfdHNjOwo+IC0gICAgbG9mZl90IGZpbGVfb2Zmc2V0Owo+IC0gICAgbG9mZl90IG5leHRfY3B1 X2NoYW5nZV9vZmZzZXQ7Cj4gKyAgICBvZmZfdCBmaWxlX29mZnNldDsKPiArICAgIG9mZl90IG5l eHRfY3B1X2NoYW5nZV9vZmZzZXQ7Cj4gICAgICBzdHJ1Y3QgcmVjb3JkX2luZm8gcmk7Cj4gICAg ICBpbnQgbGFzdF9jcHVfY2hhbmdlX3BpZDsKPiAgICAgIGludCBwb3dlcl9zdGF0ZTsKPiBAQCAt MTg5OCw3ICsxODk4LDcgQEAgdm9pZCBfX2ZpbGxfaW5fcmVjb3JkX2luZm8oc3RydWN0IHBjcHVf aW5mbyAqcCk7Cj4gIAo+ICBzdHJ1Y3Qgewo+ICAgICAgaW50IG1heF9hY3RpdmVfcGNwdTsKPiAt ICAgIGxvZmZfdCBsYXN0X2Vwb2NoX29mZnNldDsKPiArICAgIG9mZl90IGxhc3RfZXBvY2hfb2Zm c2V0Owo+ICAgICAgaW50IGVhcmx5X2VvZjsKPiAgICAgIGludCBsb3N0X2NwdXM7Cj4gICAgICB0 c2NfdCBub3c7Cj4gQEAgLTE5MzcsNyArMTkzNyw3IEBAIGNoYXIgKiBwY3B1X3N0cmluZyhpbnQg cGNwdSk7Cj4gIHZvaWQgcGNwdV9zdHJpbmdfZHJhdyhzdHJ1Y3QgcGNwdV9pbmZvICpwKTsKPiAg dm9pZCBwcm9jZXNzX2dlbmVyaWMoc3RydWN0IHJlY29yZF9pbmZvICpyaSk7Cj4gIHZvaWQgZHVt cF9nZW5lcmljKEZJTEUgKmYsIHN0cnVjdCByZWNvcmRfaW5mbyAqcmkpOwo+IC1zc2l6ZV90IF9f cmVhZF9yZWNvcmQoc3RydWN0IHRyYWNlX3JlY29yZCAqcmVjLCBsb2ZmX3Qgb2Zmc2V0KTsKPiAr c3NpemVfdCBfX3JlYWRfcmVjb3JkKHN0cnVjdCB0cmFjZV9yZWNvcmQgKnJlYywgb2ZmX3Qgb2Zm c2V0KTsKPiAgdm9pZCBlcnJvcihlbnVtIGVycm9yX2xldmVsIGwsIHN0cnVjdCByZWNvcmRfaW5m byAqcmkpOwo+ICB2b2lkIHVwZGF0ZV9pb19hZGRyZXNzKHN0cnVjdCBpb19hZGRyZXNzICoqIGxp c3QsIHVuc2lnbmVkIGludCBwYSwgaW50IGRpciwKPiAgICAgICAgICAgICAgICAgICAgICAgICB0 c2NfdCBhcmNfY3ljbGVzLCB1bnNpZ25lZCBpbnQgdmEpOwo+IEBAIC04NTEyLDcgKzg1MTIsNyBA QCB2b2lkIGFjdGl2YXRlX2Vhcmx5X2VvZih2b2lkKSB7Cj4gICAgICB9Cj4gIH0KPiAgCj4gLWxv ZmZfdCBzY2FuX2Zvcl9uZXdfcGNwdShsb2ZmX3Qgb2Zmc2V0KSB7Cj4gK29mZl90IHNjYW5fZm9y X25ld19wY3B1KG9mZl90IG9mZnNldCkgewo+ICAgICAgc3NpemVfdCByOwo+ICAgICAgc3RydWN0 IHRyYWNlX3JlY29yZCByZWM7Cj4gICAgICBzdHJ1Y3QgY3B1X2NoYW5nZV9kYXRhICpjZDsKPiBA QCAtOTA1MSw3ICs5MDUxLDcgQEAgdm9pZCBwcm9ncmVzc19pbml0KHZvaWQpIHsKPiAgCj4gIH0K PiAgCj4gLXZvaWQgcHJvZ3Jlc3NfdXBkYXRlKGxvZmZfdCBvZmZzZXQpIHsKPiArdm9pZCBwcm9n cmVzc191cGRhdGUob2ZmX3Qgb2Zmc2V0KSB7Cj4gICAgICBsb25nIGxvbmcgcDsKPiAgCj4gICAg ICBwID0gKCBvZmZzZXQgKiAxMDAgKSAvIEcuZmlsZV9zaXplOwo+IEBAIC05MDg5LDcgKzkwODks NyBAQCB2b2lkIHByb2dyZXNzX2ZpbmlzaCh2b2lkKSB7Cj4gICAgICB9Cj4gIH0KPiAgCj4gLXNz aXplX3QgX19yZWFkX3JlY29yZChzdHJ1Y3QgdHJhY2VfcmVjb3JkICpyZWMsIGxvZmZfdCBvZmZz ZXQpCj4gK3NzaXplX3QgX19yZWFkX3JlY29yZChzdHJ1Y3QgdHJhY2VfcmVjb3JkICpyZWMsIG9m Zl90IG9mZnNldCkKPiAgewo+ICAgICAgc3NpemVfdCByLCByc2l6ZTsKPiAgCj4gQEAgLTkxNzIs NyArOTE3Miw3IEBAIHZvaWQgX19maWxsX2luX3JlY29yZF9pbmZvKHN0cnVjdCBwY3B1X2luZm8g KnApCj4gIH0KPiAgCj4gIHNzaXplX3QgcmVhZF9yZWNvcmQoc3RydWN0IHBjcHVfaW5mbyAqIHAp IHsKPiAtICAgIGxvZmZfdCAqIG9mZnNldDsKPiArICAgIG9mZl90ICogb2Zmc2V0Owo+ICAgICAg c3RydWN0IHJlY29yZF9pbmZvICpyaTsKPiAgCj4gICAgICBvZmZzZXQgPSAmcC0+ZmlsZV9vZmZz ZXQ7Cj4gQEAgLTk0ODksNyArOTQ4OSw3IEBAIHZvaWQgcmVwb3J0X3BjcHUodm9pZCkgewo+ICAK PiAgdm9pZCBpbml0X3BjcHVzKHZvaWQpIHsKPiAgICAgIGludCBpPTA7Cj4gLSAgICBsb2ZmX3Qg b2Zmc2V0ID0gMDsKPiArICAgIG9mZl90IG9mZnNldCA9IDA7Cj4gIAo+ICAgICAgZm9yKGk9MDsg aTxNQVhfQ1BVUzsgaSsrKQo+ICAgICAgewo+IEBAIC0xMDM1OCwxMiArMTAzNTgsMTIgQEAgaW50 IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkgewo+ICAgICAgaWYgKEcudHJhY2VfZmlsZSA9 PSBOVUxMKQo+ICAgICAgICAgIGV4aXQoMSk7Cj4gIAo+IC0gICAgaWYgKCAoRy5mZCA9IG9wZW4o Ry50cmFjZV9maWxlLCBPX1JET05MWXxPX0xBUkdFRklMRSkpIDwgMCkgewo+ICsgICAgaWYgKCAo Ry5mZCA9IG9wZW4oRy50cmFjZV9maWxlLCBPX1JET05MWSkpIDwgMCkgewo+ICAgICAgICAgIHBl cnJvcigib3BlbiIpOwo+ICAgICAgICAgIGVycm9yKEVSUl9TWVNURU0sIE5VTEwpOwo+ICAgICAg fSBlbHNlIHsKPiAtICAgICAgICBzdHJ1Y3Qgc3RhdDY0IHM7Cj4gLSAgICAgICAgZnN0YXQ2NChH LmZkLCAmcyk7Cj4gKyAgICAgICAgc3RydWN0IHN0YXQgczsKPiArICAgICAgICBmc3RhdChHLmZk LCAmcyk7Cj4gICAgICAgICAgRy5maWxlX3NpemUgPSBzLnN0X3NpemU7Cj4gICAgICB9Cj4gIAo+ IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==