From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH 1/2] xen{trace/analyze}: don't use 64bit
 versions of libc functions
Date: Mon, 22 Jun 2015 11:59:55 +0200
Message-ID: <5587DC9B.3050403@citrix.com>
References: <1434704305-64692-1-git-send-email-roger.pau@citrix.com>
	<1434704305-64692-2-git-send-email-roger.pau@citrix.com>
	<5587D094.9030304@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=60808c7ad=roger.pau@citrix.com>)
	id 1Z6yWi-0004BO-BX
	for xen-devel@lists.xenproject.org; Mon, 22 Jun 2015 10:00:28 +0000
In-Reply-To: <5587D094.9030304@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Olaf Hering <olaf@aepfle.de>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 22/06/15 a les 11.08, George Dunlap ha escrit:
> On 06/19/2015 09:58 AM, Roger Pau Monne wrote:
>> This is not needed, neither encouraged. Configure already checks
>> _FILE_OFFSET_BITS and appends it when needed, so that the right functions
>> are used. Also remove the usage of loff_t and O_LARGEFILE for the same
>> reason.
> 
> Just so I understand -- are you saying that configure at the tools
> directory level will notice that Linux can handle 64-bit file operations
> and use them automatically?

Yes, according to the man page [1]:

"Over time, increases in the size of the stat structure have led to
three successive versions of stat(): sys_stat() (slot __NR_oldstat),
sys_newstat() (slot __NR_stat), and sys_stat64() (new in kernel 2.4;
slot __NR_stat64). The glibc stat() wrapper function hides these details
from applications, invoking the most recent version of the system call
provided by the kernel, and repacking the returned information if
required for old binaries. Similar remarks apply for fstat() and lstat()."

Roger.

[1] http://linux.die.net/man/2/fstat64