Re: [PATCH 2/2] configure: check for argp

[George Dunlap <george.dunlap@eu.citrix.com>]

On 06/22/2015 12:10 PM, Wei Liu wrote:
> On Mon, Jun 22, 2015 at 11:55:44AM +0100, George Dunlap wrote:
>> On 06/22/2015 11:45 AM, Wei Liu wrote:
>>> On Mon, Jun 22, 2015 at 11:12:27AM +0100, George Dunlap wrote:
>>>> On 06/19/2015 09:58 AM, Roger Pau Monne wrote:
>>>>> argp is only present in the GNU C library, so add a specific check for it in
>>>>> configure. Also check if -largp is needed for linking against it.
>>>>>
>>>>> Please run autoconf after applying.
>>>>>
>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>> Cc: George Dunlap <george.dunlap@eu.citrix.com>
>>>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>>>> Cc: Wei Liu <wei.liu2@citrix.com>
>>>>> Cc: Olaf Hering <olaf@aepfle.de>
>>>>> ---
>>>>>  config/Tools.mk.in      | 1 +
>>>>>  tools/configure.ac      | 4 ++++
>>>>>  tools/xentrace/Makefile | 2 +-
>>>>>  3 files changed, 6 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
>>>>> index aef9ed6..9bd5f6c 100644
>>>>> --- a/config/Tools.mk.in
>>>>> +++ b/config/Tools.mk.in
>>>>> @@ -78,5 +78,6 @@ CONFIG_GCRYPT       := @libgcrypt@
>>>>>  EXTFS_LIBS          := @EXTFS_LIBS@
>>>>>  CURSES_LIBS         := @CURSES_LIBS@
>>>>>  TINFO_LIBS          := @TINFO_LIBS@
>>>>> +ARGP_LDFLAGS        := @argp_ldflags@
>>>>>  
>>>>>  FILE_OFFSET_BITS    := @FILE_OFFSET_BITS@
>>>>> diff --git a/tools/configure.ac b/tools/configure.ac
>>>>> index 1a06ddf..5eb4799 100644
>>>>> --- a/tools/configure.ac
>>>>> +++ b/tools/configure.ac
>>>>> @@ -356,6 +356,10 @@ AC_CHECK_LIB([yajl], [yajl_alloc], [],
>>>>>  AC_CHECK_LIB([z], [deflateCopy], [], [AC_MSG_ERROR([Could not find zlib])])
>>>>>  AC_CHECK_LIB([iconv], [libiconv_open], [libiconv="y"], [libiconv="n"])
>>>>>  AC_SUBST(libiconv)
>>>>> +AC_CHECK_HEADER([argp.h], [
>>>>> +AC_CHECK_LIB([argp], [argp_usage], [argp_ldflags="-largp"])
>>>>> +], [AC_MSG_ERROR([Could not find argp])])
>>>>> +AC_SUBST(argp_ldflags)
>>>>
>>>> Sorry if my config-fu isn't very good:  Is this basically requiring the
>>>> user to have argp available at configure time?  Does this make it more
>>>> difficult to build on BSDs?  Or is it just a matter of adding one more
>>>> library to the already long list of dependencies?
>>>
>>> This is just to make that dependency explicit. This is a step towards
>>> the right direction.  It's not going to make it easier or harder to
>>> build on BSDs.
>>
>> Well the reason I was asking is that if it would be a big hassle for
>> someone building on BSDs to install the argp library, then a better
>> option might to just not build xenalyze.
>>
>> On the other hand, if it's no more difficult than installing libyajl (or
>> any of the other dozen dependencies), then adding a dependency is fine.
>>  And naturally in that case making the dependency explicit is the right
>> thing to do.
>>
> 
> Yes, package argp exist in FreeBSD and NetBSD.

In which case:

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>