From: Ian Abbott <abbotti@mev.co.uk>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: comedi: don't split Author string
Date: Mon, 22 Jun 2015 12:44:37 +0100 [thread overview]
Message-ID: <5587F525.8010704@mev.co.uk> (raw)
In-Reply-To: <20150620201423.GA27788@turing>
On 20/06/15 21:14, Luis de Bethencourt wrote:
> fixes checkpatch.pl WARNING: quoted string split across lines
>
> +MODULE_AUTHOR("David A. Schleef <ds@schleef.org>, "
> + "Frank Mori Hess <fmhess@users.sourceforge.net>");
>
> total: 0 errors, 1 warnings, 114 lines checked
>
> Modules with multiple authors have a MODULE_AUTHOR line for each one.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
> drivers/staging/comedi/drivers/das08_cs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c
> index 93fab68..9c02b17 100644
> --- a/drivers/staging/comedi/drivers/das08_cs.c
> +++ b/drivers/staging/comedi/drivers/das08_cs.c
> @@ -108,7 +108,7 @@ static struct pcmcia_driver das08_cs_driver = {
> };
> module_comedi_pcmcia_driver(driver_das08_cs, das08_cs_driver);
>
> -MODULE_AUTHOR("David A. Schleef <ds@schleef.org>, "
> - "Frank Mori Hess <fmhess@users.sourceforge.net>");
> +MODULE_AUTHOR("David A. Schleef <ds@schleef.org>");
> +MODULE_AUTHOR("Frank Mori Hess <fmhess@users.sourceforge.net>");
> MODULE_DESCRIPTION("Comedi driver for ComputerBoards DAS-08 PCMCIA boards");
> MODULE_LICENSE("GPL");
>
Okay, it would be nice if the patch subject line mentioned the name of
the module, but this is the only one in COMEDI with a split author line.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2015-06-22 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 20:14 [PATCH] staging: comedi: don't split Author string Luis de Bethencourt
2015-06-22 11:44 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5587F525.8010704@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.