From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 3/3] gnttab: clean up gnttab_set_version()
Date: Mon, 22 Jun 2015 13:01:12 +0100
Message-ID: <5587F908.9030007@citrix.com>
References: <558810070200007800087749@mail.emea.novell.com>
	<558811A80200007800087761@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=608d9a61a=Andrew.Cooper3@citrix.com>)
	id 1Z70Pl-000342-AC
	for xen-devel@lists.xenproject.org; Mon, 22 Jun 2015 12:01:25 +0000
In-Reply-To: <558811A80200007800087761@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 22/06/15 12:46, Jan Beulich wrote:
> - drop pointless nr_grant_entries() check from loop over reserved
>   entries (adding suitable BUILD_BUG_ON()s to validate that)
> - adjust types
> - rename d to currd
> - formatting
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with one suggestion.

> @@ -2625,66 +2633,78 @@ gnttab_set_version(XEN_GUEST_HANDLE_PARA
>          break;
>      }
>  
> -    /* Preserve the first 8 entries (toolstack reserved grants) */
> -    if ( gt->gt_version == 1 )
> -    {
> -        memcpy(reserved_entries, &shared_entry_v1(gt, 0), sizeof(reserved_entries));
> -    }
> -    else if ( gt->gt_version == 2 )
> +    /* Preserve the first 8 entries (toolstack reserved grants). */
> +    switch ( gt->gt_version )
>      {
> -        for ( i = 0; i < GNTTAB_NR_RESERVED_ENTRIES && i < nr_grant_entries(gt); i++ )
> +    case 1:
> +        memcpy(reserved_entries, &shared_entry_v1(gt, 0),
> +               sizeof(reserved_entries));
> +        break;
> +    case 2:
> +        for ( i = 0; i < GNTTAB_NR_RESERVED_ENTRIES; i++ )
>          {
> -            int flags = status_entry(gt, i);
> -            flags |= shared_entry_v2(gt, i).hdr.flags;
> -            if ((flags & GTF_type_mask) == GTF_permit_access)
> +            unsigned int flags = shared_entry_v2(gt, i).hdr.flags;
> +
> +            switch ( flags & GTF_type_mask )
>              {
> -                reserved_entries[i].flags = flags;
> +            case GTF_permit_access:
> +                reserved_entries[i].flags = flags | status_entry(gt, i);
>                  reserved_entries[i].domid = shared_entry_v2(gt, i).hdr.domid;
>                  reserved_entries[i].frame = shared_entry_v2(gt, i).full_page.frame;
> -            }
> -            else
> -            {
> -                if ((flags & GTF_type_mask) != GTF_invalid)
> -                    gdprintk(XENLOG_INFO, "d%d: bad flags %x in grant %d when switching grant version\n",
> -                           d->domain_id, flags, i);
> +                break;
> +            default:
> +                gdprintk(XENLOG_INFO,
> +                         "bad flags %x in grant %u when switching version\n",
> +                         flags, i);

A 0x for flags, to avoid decimal confusion.