Re: [PATCH V6 05/17] perf tools: Add Intel PT instruction decoder

[Adrian Hunter <adrian.hunter@intel.com>]

On 19/06/15 18:44, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jun 18, 2015 at 07:29:41PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, May 29, 2015 at 04:33:33PM +0300, Adrian Hunter escreveu:
>>> Add support for decoding instructions for Intel Processor Trace.  The
>>> kernel x86 instruction decoder is used for this.
>>
>> Ok, but we don't access kernel header files directly, and:
>>
>> [acme@zoo linux]$ find . -name "insn.h"
>> ./arch/x86/include/asm/insn.h
>> ./arch/arm64/include/asm/insn.h
>> ./arch/arm/include/asm/insn.h
>> [acme@zoo linux]$ find /usr/include -name "insn.h"
>> [acme@zoo linux]$ 
>>
>> But I need to look more into this patch to figure out if this is
>> something generated at build time, etc, but before that I found a
>> problem:
>>
>> So:
>>
>>> +inat_tables_script = ../../arch/x86/tools/gen-insn-attr-x86.awk
>>> +inat_tables_maps = ../../arch/x86/lib/x86-opcode-map.txt
>>
>> These need to go into tools/perf/MANIFEST, so that:
> 
> So, after adding:
> 
> diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
> index fe50a1b34aa0..4e5662d8c274 100644
> --- a/tools/perf/MANIFEST
> +++ b/tools/perf/MANIFEST
> @@ -58,6 +58,13 @@ include/linux/stringify.h
>  lib/hweight.c
>  lib/rbtree.c
>  include/linux/swab.h
> +arch/x86/lib/insn.c
> +arch/x86/lib/inat.c
> +arch/x86/include/asm/insn.h
> +arch/x86/include/asm/inat.h
> +arch/x86/include/asm/inat_types.h
> +arch/x86/tools/gen-insn-attr-x86.awk
> +arch/x86/lib/x86-opcode-map.txt
>  arch/*/include/asm/unistd*.h
>  arch/*/include/uapi/asm/unistd*.h
>  arch/*/include/uapi/asm/perf_regs.h
> 
> The test passes:
> 
> [acme@zoo linux]$ make -C tools/perf -f tests/make tarpkg && echo Ok
> make: Entering directory '/home/git/linux/tools/perf'
> - tarpkg: ./tests/perf-targz-src-pkg .
> make: Leaving directory '/home/git/linux/tools/perf'
> Ok
> [acme@zoo linux]$
> 
> Merging these changes with this changeset to continue testing...

Thank you! :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/