From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: Ingo Molnar <mingo@kernel.org>, Dmitry Vyukov <dvyukov@google.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
Andrey Konovalov <adech.fo@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>,
Alexander Popov <alpopov@ptsecurity.com>,
Alexander Potapenko <glider@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86_64: kasan: add message about kasan being initialized
Date: Mon, 22 Jun 2015 19:06:59 +0300 [thread overview]
Message-ID: <558832A3.9060309@samsung.com> (raw)
In-Reply-To: <20150620131813.GA6534@gmail.com>
On 06/20/2015 04:18 PM, Ingo Molnar wrote:
>
> Please call it 'kasan' or 'KASAN', and also explain it in the message and prefix
> it properly with the subsystem name (kasan), so something like:
>
> pr_info("kasan: Kernel Address SANitizer (KASAN) initialized\n");
>
> Other kasan messages should also carry a 'kasan: ' prefix, so that it's
> unambiguous what generated the message, and also to make it easier to grep out of
> logs.
>
This patch adds "kasan: " prefix for all messages from this file ( +#define pr_fmt(fmt) "kasan: " fmt )
I'm agree with Dmitry, I would choose kasan name too.
In this case, adding explanation in the message will produce too much kasans in one short message:
kasan: Kernel address sanitizer (kasan) initialized
Perhaps it would be better to keep this patch as is. Ok?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-22 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 17:17 [PATCH 1/3] x86_64: kasan: flush tlbs after switching cr3 Andrey Ryabinin
2015-06-19 17:17 ` [PATCH 2/3] x86_64: kasan: fix boot crash on AMD processors Andrey Ryabinin
[not found] ` <1434734247-29153-3-git-send-email-a.ryabinin@samsung.com>
[not found] ` <CACT4Y+ZRJk+6QHGhN3Vz=Hnv=PjB2P-P-Y9UiZAHNsvO=7v_MA@mail.gmail.com>
[not found] ` <20150620131813.GA6534@gmail.com>
2015-06-22 16:06 ` Andrey Ryabinin [this message]
2015-06-30 5:23 ` [PATCH 3/3] x86_64: kasan: add message about kasan being initialized Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558832A3.9060309@samsung.com \
--to=a.ryabinin@samsung.com \
--cc=adech.fo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alpopov@ptsecurity.com \
--cc=bp@alien8.de \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.