All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Annotate deleting functions with external lock via lockdep
Date: Mon, 22 Jun 2015 19:00:24 +0200	[thread overview]
Message-ID: <55883F28.9050806@meshcoding.com> (raw)
In-Reply-To: <1434795203-21947-1-git-send-email-sven@narfation.org>

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]



On 20/06/15 12:13, Sven Eckelmann wrote:
> Functions which use (h)list_del* are requiring correct locking when they
> operate on global lists. Most of the time the search in the list and the
> delete are done in the same function. All other cases should have it
> visible that they require a special lock to avoid race conditions.
> 
> Lockdep asserts can be used to check these problem during runtime when the
> lockdep functionality is enabled.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>

Thanks for this patch Sven!
This should reduce the likelihood of having of making mistakes in the
future (I hope!)

Acked-by: Antonio Quartulli <antonio@meshcoding.com>



-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-06-22 17:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-20 10:13 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Annotate deleting functions with external lock via lockdep Sven Eckelmann
2015-06-20 10:13 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Add lockdep_asserts for documented external locks Sven Eckelmann
2015-06-22 17:17   ` Antonio Quartulli
2015-06-22 17:00 ` Antonio Quartulli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55883F28.9050806@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.