From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z75ZC-00016J-Gz for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z75Z5-0002cR-JD for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:31:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51865 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z75Z5-0002c0-CB for qemu-devel@nongnu.org; Mon, 22 Jun 2015 13:31:23 -0400 Message-ID: <5588466A.1030902@suse.de> Date: Mon, 22 Jun 2015 19:31:22 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <00c96d447252bc1333e14e626611f4f5a58f9bf5.1434432813.git.crosthwaite.peter@gmail.com> In-Reply-To: <00c96d447252bc1333e14e626611f4f5a58f9bf5.1434432813.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, edgar.iglesias@gmail.com, Peter Crosthwaite Am 16.06.2015 um 07:46 schrieb Peter Crosthwaite: > Use the cpu_set_pc helper which will take care of CPUClass retrieval > for us. >=20 > Signed-off-by: Peter Crosthwaite > --- > gdbstub.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/gdbstub.c b/gdbstub.c > index 75563db..ceb60ac 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -754,12 +754,9 @@ static void gdb_breakpoint_remove_all(void) > static void gdb_set_cpu_pc(GDBState *s, target_ulong pc) > { > CPUState *cpu =3D s->c_cpu; > - CPUClass *cc =3D CPU_GET_CLASS(cpu); > =20 > cpu_synchronize_state(cpu); > - if (cc->set_pc) { > - cc->set_pc(cpu, pc); > - } > + cpu_set_pc(cpu, pc, NULL); I believe this argument will probably go away; otherwise this should've been &error_abort or something instead of NULL. Regards, Andreas > } > =20 > static CPUState *find_cpu(uint32_t thread_id) >=20 --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)