From: "Markus Böhme" <markus.boehme@mailbox.org>
To: "Abdul, Hussain (H.)" <habdul@visteon.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"abbotti@mev.co.uk" <abbotti@mev.co.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial if-return sequence
Date: Mon, 22 Jun 2015 22:39:20 +0200 [thread overview]
Message-ID: <55887278.3010705@mailbox.org> (raw)
In-Reply-To: <1434953361-23444-3-git-send-email-habdul@visteon.com>
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
> return result;
>
> s = &dev->subdevices[2];
> - result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
> - dioP2ExpansionIO8Bit);
> - if (result)
> - return result;
> -
> - return 0;
> + return subdev_8255_init(dev, s, daqboard2000_8255_cb,
> + dioP2ExpansionIO8Bit);
> }
What do you think about horizontally aligning the parameters in the second line?
They were previously.
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-22 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 6:10 [PATCH v2 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return sequence Abdul, Hussain (H.)
2015-06-22 6:10 ` [PATCH v2 2/6] Staging: comedi: fl512: " Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 3/6] Staging: combine: daqboard2000: " Abdul, Hussain (H.)
2015-06-22 20:39 ` Markus Böhme [this message]
2015-06-22 6:11 ` [PATCH v2 4/6] Staging: comedi: dac02: " Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 5/6] Staging: comedi: ni_daq_dio24: " Abdul, Hussain (H.)
2015-06-22 6:11 ` [PATCH v2 6/6] Staging: comedi: s626: " Abdul, Hussain (H.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55887278.3010705@mailbox.org \
--to=markus.boehme@mailbox.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=habdul@visteon.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.