From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Pitoiset Subject: Re: [Nouveau] [RFC PATCH 5/8] nv50: prevent NULL pointer dereference with pipe_query functions Date: Mon, 22 Jun 2015 23:02:17 +0200 Message-ID: <558877D9.8040501@gmail.com> References: <1435006399-2088-1-git-send-email-samuel.pitoiset@gmail.com> <1435006399-2088-6-git-send-email-samuel.pitoiset@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: mesa-dev-bounces@lists.freedesktop.org Sender: "mesa-dev" To: Ilia Mirkin Cc: "nouveau@lists.freedesktop.org" , "mesa-dev@lists.freedesktop.org" List-Id: nouveau.vger.kernel.org CgpPbiAwNi8yMi8yMDE1IDEwOjUyIFBNLCBJbGlhIE1pcmtpbiB3cm90ZToKPiBJZiBxdWVyeV9j cmVhdGUgZmFpbHMsIHdoeSB3b3VsZCBhbnkgb2YgdGhlc2UgZnVuY3Rpb25zIGdldCBjYWxsZWQ/ CgpCZWNhdXNlIHRoZSBIVUQgZG9lc24ndCBjaGVjayBpZiBxdWVyeV9jcmVhdGUoKSBmYWlscyBh bmQgaXQgY2FsbHMgb3RoZXIgCnBpcGVfcXVlcnkgZnVuY3Rpb25zIHdpdGggTlVMTCBwb2ludGVy IGluc3RlYWQgb2YgYSB2YWxpZCBxdWVyeSBvYmplY3QuCgo+Cj4gT24gTW9uLCBKdW4gMjIsIDIw MTUgYXQgNDo1MyBQTSwgU2FtdWVsIFBpdG9pc2V0Cj4gPHNhbXVlbC5waXRvaXNldEBnbWFpbC5j b20+IHdyb3RlOgo+PiBUaGlzIG1heSBoYXBwZW4gd2hlbiBudjUwX3F1ZXJ5X2NyZWF0ZSgpIGZh aWxzIHRvIGNyZWF0ZSBhIG5ldyBxdWVyeS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogU2FtdWVsIFBp dG9pc2V0IDxzYW11ZWwucGl0b2lzZXRAZ21haWwuY29tPgo+PiAtLS0KPj4gICBzcmMvZ2FsbGl1 bS9kcml2ZXJzL25vdXZlYXUvbnY1MC9udjUwX3F1ZXJ5LmMgfCAxNSArKysrKysrKysrKysrKy0K Pj4gICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pgo+ PiBkaWZmIC0tZ2l0IGEvc3JjL2dhbGxpdW0vZHJpdmVycy9ub3V2ZWF1L252NTAvbnY1MF9xdWVy eS5jIGIvc3JjL2dhbGxpdW0vZHJpdmVycy9ub3V2ZWF1L252NTAvbnY1MF9xdWVyeS5jCj4+IGlu ZGV4IDU1ZmNhYzguLjExNjIxMTAgMTAwNjQ0Cj4+IC0tLSBhL3NyYy9nYWxsaXVtL2RyaXZlcnMv bm91dmVhdS9udjUwL252NTBfcXVlcnkuYwo+PiArKysgYi9zcmMvZ2FsbGl1bS9kcml2ZXJzL25v dXZlYXUvbnY1MC9udjUwX3F1ZXJ5LmMKPj4gQEAgLTk2LDYgKzk2LDkgQEAgbnY1MF9xdWVyeV9h bGxvY2F0ZShzdHJ1Y3QgbnY1MF9jb250ZXh0ICpudjUwLCBzdHJ1Y3QgbnY1MF9xdWVyeSAqcSwg aW50IHNpemUpCj4+ICAgc3RhdGljIHZvaWQKPj4gICBudjUwX3F1ZXJ5X2Rlc3Ryb3koc3RydWN0 IHBpcGVfY29udGV4dCAqcGlwZSwgc3RydWN0IHBpcGVfcXVlcnkgKnBxKQo+PiAgIHsKPj4gKyAg IGlmICghcHEpCj4+ICsgICAgICByZXR1cm47Cj4+ICsKPj4gICAgICBudjUwX3F1ZXJ5X2FsbG9j YXRlKG52NTBfY29udGV4dChwaXBlKSwgbnY1MF9xdWVyeShwcSksIDApOwo+PiAgICAgIG5vdXZl YXVfZmVuY2VfcmVmKE5VTEwsICZudjUwX3F1ZXJ5KHBxKS0+ZmVuY2UpOwo+PiAgICAgIEZSRUUo bnY1MF9xdWVyeShwcSkpOwo+PiBAQCAtMTUyLDYgKzE1NSw5IEBAIG52NTBfcXVlcnlfYmVnaW4o c3RydWN0IHBpcGVfY29udGV4dCAqcGlwZSwgc3RydWN0IHBpcGVfcXVlcnkgKnBxKQo+PiAgICAg IHN0cnVjdCBub3V2ZWF1X3B1c2hidWYgKnB1c2ggPSBudjUwLT5iYXNlLnB1c2hidWY7Cj4+ICAg ICAgc3RydWN0IG52NTBfcXVlcnkgKnEgPSBudjUwX3F1ZXJ5KHBxKTsKPj4KPj4gKyAgIGlmICgh cHEpCj4+ICsgICAgICByZXR1cm4gRkFMU0U7Cj4+ICsKPj4gICAgICAvKiBGb3Igb2NjbHVzaW9u IHF1ZXJpZXMgd2UgaGF2ZSB0byBjaGFuZ2UgdGhlIHN0b3JhZ2UsIGJlY2F1c2UgYSBwcmV2aW91 cwo+PiAgICAgICAqIHF1ZXJ5IG1pZ2h0IHNldCB0aGUgaW5pdGlhbCByZW5kZXIgY29uaXRpb24g dG8gRkFMU0UgZXZlbiAqYWZ0ZXIqIHdlIHJlLQo+PiAgICAgICAqIGluaXRpYWxpemVkIGl0IHRv IFRSVUUuCj4+IEBAIC0yMTgsNiArMjI0LDkgQEAgbnY1MF9xdWVyeV9lbmQoc3RydWN0IHBpcGVf Y29udGV4dCAqcGlwZSwgc3RydWN0IHBpcGVfcXVlcnkgKnBxKQo+PiAgICAgIHN0cnVjdCBub3V2 ZWF1X3B1c2hidWYgKnB1c2ggPSBudjUwLT5iYXNlLnB1c2hidWY7Cj4+ICAgICAgc3RydWN0IG52 NTBfcXVlcnkgKnEgPSBudjUwX3F1ZXJ5KHBxKTsKPj4KPj4gKyAgIGlmICghcHEpCj4+ICsgICAg ICByZXR1cm47Cj4+ICsKPj4gICAgICBxLT5zdGF0ZSA9IE5WNTBfUVVFUllfU1RBVEVfRU5ERUQ7 Cj4+Cj4+ICAgICAgc3dpdGNoIChxLT50eXBlKSB7Cj4+IEBAIC0yOTQsOSArMzAzLDEyIEBAIG52 NTBfcXVlcnlfcmVzdWx0KHN0cnVjdCBwaXBlX2NvbnRleHQgKnBpcGUsIHN0cnVjdCBwaXBlX3F1 ZXJ5ICpwcSwKPj4gICAgICB1aW50NjRfdCAqcmVzNjQgPSAodWludDY0X3QgKilyZXN1bHQ7Cj4+ ICAgICAgdWludDMyX3QgKnJlczMyID0gKHVpbnQzMl90ICopcmVzdWx0Owo+PiAgICAgIGJvb2xl YW4gKnJlczggPSAoYm9vbGVhbiAqKXJlc3VsdDsKPj4gLSAgIHVpbnQ2NF90ICpkYXRhNjQgPSAo dWludDY0X3QgKilxLT5kYXRhOwo+PiArICAgdWludDY0X3QgKmRhdGE2NDsKPj4gICAgICBpbnQg aTsKPj4KPj4gKyAgIGlmICghcHEpCj4+ICsgICAgICByZXR1cm4gRkFMU0U7Cj4+ICsKPj4gICAg ICBpZiAocS0+c3RhdGUgIT0gTlY1MF9RVUVSWV9TVEFURV9SRUFEWSkKPj4gICAgICAgICBudjUw X3F1ZXJ5X3VwZGF0ZShxKTsKPj4KPj4gQEAgLTMxNCw2ICszMjYsNyBAQCBudjUwX3F1ZXJ5X3Jl c3VsdChzdHJ1Y3QgcGlwZV9jb250ZXh0ICpwaXBlLCBzdHJ1Y3QgcGlwZV9xdWVyeSAqcHEsCj4+ ICAgICAgfQo+PiAgICAgIHEtPnN0YXRlID0gTlY1MF9RVUVSWV9TVEFURV9SRUFEWTsKPj4KPj4g KyAgIGRhdGE2NCA9ICh1aW50NjRfdCAqKXEtPmRhdGE7Cj4+ICAgICAgc3dpdGNoIChxLT50eXBl KSB7Cj4+ICAgICAgY2FzZSBQSVBFX1FVRVJZX0dQVV9GSU5JU0hFRDoKPj4gICAgICAgICByZXM4 WzBdID0gVFJVRTsKPj4gLS0KPj4gMi40LjQKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPj4gTm91dmVhdSBtYWlsaW5nIGxpc3QKPj4gTm91dmVh dUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL25vdXZlYXUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCm1lc2EtZGV2IG1haWxpbmcgbGlzdAptZXNhLWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L21lc2EtZGV2Cg==