From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Antigcc bitfield bikeshed
Date: Mon, 22 Jun 2015 14:19:51 -0700 [thread overview]
Message-ID: <55887BF7.3040002@virtuousgeek.org> (raw)
In-Reply-To: <20150617151022.GE23637@phenom.ffwll.local>
On 06/17/2015 08:10 AM, Daniel Vetter wrote:
> On Wed, Jun 17, 2015 at 05:28:20PM +0300, Jani Nikula wrote:
>> On Wed, 17 Jun 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> Here's an idea I want to float to see if anyone has a better idea.
>>
>> I'll give it some thought, but it pains me that things like this make it
>> harder for source code cross referencers and even grep to find what you
>> you're looking for.
>
> The minimal thing we've tossed around on irc (and we only need minimal
> since there's just a few places that need the raw flags field) is to
> hardcode the offsets and check them at runtime ...
This one scares me a lot too; is there a thread on the memory ordering
macros somewhere I can look at? The ordering constraints on x86 are
pretty specific... if we need to annotate things in the code somehow
that could be a plus (generally every *mb() should have a fat comment
explaining the issue), but this seems like overkill at first glance.
Jesse
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-22 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:47 [PATCH] Antigcc bitfield bikeshed Chris Wilson
2015-06-17 14:28 ` Jani Nikula
2015-06-17 15:10 ` Daniel Vetter
2015-06-22 21:19 ` Jesse Barnes [this message]
2015-06-23 6:53 ` Daniel Vetter
2015-06-24 22:56 ` Jesse Barnes
2015-06-25 7:33 ` Daniel Vetter
2015-06-25 15:30 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55887BF7.3040002@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.