From: Alexander Graf <agraf@suse.de>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Peek dont read for vmdescription
Date: Tue, 23 Jun 2015 00:18:15 +0200 [thread overview]
Message-ID: <558889A7.2020408@suse.de> (raw)
In-Reply-To: <1434984574-21037-1-git-send-email-dgilbert@redhat.com>
On 22.06.15 16:49, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The VMDescription section maybe after the EOF mark, the current code
> does a 'qemu_get_byte' and either gets the header byte identifying the
> description or an error (which it ignores). Doing the 'get' upsets
> RDMA which hangs on old machine types without the VMDescription.
>
> Using 'qemu_peek_byte' avoids that.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fun. I did actually use peek at first and then figured it's the same as
read in the qemu file implementation. Have you figured out why exactly
peek does make a difference for the RDMA case?
Alex
next prev parent reply other threads:[~2015-06-22 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 14:49 [Qemu-devel] [PATCH] Peek dont read for vmdescription Dr. David Alan Gilbert (git)
2015-06-22 22:18 ` Alexander Graf [this message]
2015-06-23 8:37 ` Dr. David Alan Gilbert
2015-06-23 16:37 ` Dr. David Alan Gilbert
2015-06-23 22:01 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558889A7.2020408@suse.de \
--to=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.